firebase_admin icon indicating copy to clipboard operation
firebase_admin copied to clipboard

Fix: add customAttributes to edit account request

Open schultek opened this issue 5 years ago • 7 comments

The customAttributes field is not encoded in the final request object, therefore when calling setCustomUserClaims the claims are never updated.

schultek avatar Jan 27 '21 14:01 schultek

I have tested this PR, works as expected -> should be merged

spoeck avatar Mar 10 '21 20:03 spoeck

Just spent hours trying to figure out why this isn't working.

Any reason why this hasn't been merged yet?

sgehrman avatar Dec 05 '21 11:12 sgehrman

Please merge with master :)

Cobolt77 avatar Jan 23 '22 15:01 Cobolt77

What is going on?

sgehrman avatar Aug 03 '22 06:08 sgehrman

I think maybe this hasn't been merged because there's a lot of other changes in this PR. And there's this entire other method added as well: https://github.com/appsup-dart/firebase_admin/pull/13/files#diff-0b1edb4d91ddbe43e7a03462af85a8b215c06e6a3b988f8fd2a17f7b7e27690aR38

So perhaps to aid in this being merged in, this PR could be split up into three parts:

  1. The actual fix for customAttributes (Seems like this is just one line)
  2. The new method as a proposal
  3. All other style and minor refactorings

livtanong avatar Oct 04 '22 03:10 livtanong

I think this just isn't maintained anymore. There was no activity by the owner for a long time on any issue or pr.

I have forked this for my own use a while ago, you can use this if you want, but I'm not actively working on it: https://github.com/schultek/firebase_admin

schultek avatar Oct 22 '22 18:10 schultek

Two years later and still broken.

sgehrman avatar Dec 14 '23 05:12 sgehrman