appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Bug] Fix toast message for when export default is not present in JS Object

Open infinitetrooper opened this issue 1 year ago • 8 comments

Slack Message

image (12)

undefined should not be present in the error message when body of JSObject is emptied.

Steps to reproduce

  1. Go the JSObject
  2. Remove all the code with export default
  3. Notice the error message shown in the toast.

Expected error message

JS object must contain 'export default'.

infinitetrooper avatar Sep 09 '24 07:09 infinitetrooper

Hi, Is anyone working on this ticket already?...If not, can you please provide some more details...We are not able to see the slack message attached in description

deepthin3 avatar Sep 09 '24 09:09 deepthin3

Hey @deepthin3, thanks for showing interest in this issue. After this change, I have added steps to reproduce and the expected error message. Let me know if you need more details.

rishabhrathod01 avatar Sep 09 '24 09:09 rishabhrathod01

Hi @rishabhrathod01 , I am picking this issue.

prasad-madine avatar Sep 09 '24 12:09 prasad-madine

Thanks @rishabhrathod01

deepthin3 avatar Sep 10 '24 03:09 deepthin3

@deepthin3 would like to pick this issue? I would add you as an assignee if not then @PrasadMadine could pick this up.

rishabhrathod01 avatar Sep 10 '24 04:09 rishabhrathod01

Hi @rishabhrathod01 - PrasadMadine is in my team...you can add him as assigned...thanks

deepthin3 avatar Sep 10 '24 04:09 deepthin3

Hello @rishabhrathod01 , I have fixed this issue and raised the PR Could you please review this PR when you have sometime. https://github.com/appsmithorg/appsmith/pull/36296 Thankyou

prasad-madine avatar Sep 13 '24 04:09 prasad-madine

APP-14627

linear[bot] avatar Nov 26 '25 07:11 linear[bot]