appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Bug]: Git create branch times out on the frontend even though the branch is created on the server

Open pranavkanade opened this issue 1 year ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

https://github.com/user-attachments/assets/9801789a-23cb-410f-880e-ecc02415763a

Notice how I have to refresh the list of branches to see the new branch and then manually visit it.

Steps To Reproduce

  1. Crate new branch from master.

(Found the issue on internal)

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

v1.35-snapshot

pranavkanade avatar Aug 13 '24 06:08 pranavkanade

Hi Team, I took some time to dig into the current setup and wanted to share what I found.

Right now, we’re using the window object to post messages when a user logs in (see callback.tsx#L28 ). I think it might be better to use the Broadcast Channel API to let all open tabs know about the login.

The issue with postMessage is that it only works if the current window has an opener, which is null when users open new tabs with cmd+click or by clicking a link with target="_blank". Screenshot 2024-09-19 at 9 49 56 PM Switching to the Broadcast Channel API would ensure that all tabs receive the login notification, no matter how they were opened.

What do you think?

CR4ZED avatar Sep 19 '24 16:09 CR4ZED

It sounds like that is the solution. But I'm not so familiar with web development that I can just tell. 😅 But I would code in the change as a suggestion! :D

SimonRiemertzon avatar Sep 27 '24 17:09 SimonRiemertzon

Hi @CR4ZED,

The suggested solution sounds good! Feel free to submit a PR and @sshanzel can help you with everything you need

idoshamun avatar Sep 29 '24 12:09 idoshamun

sure, I'll a raise a PR

CR4ZED avatar Sep 29 '24 14:09 CR4ZED

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Nov 08 '24 01:11 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Nov 22 '24 02:11 github-actions[bot]