fix:34329-fixed upload svg logo in the workspace api

[raushan3737]

• Fix-34329

• Fixed the workspace setting upload logo api to accept the svg type.

• Implemented a method isSvgSafe to validate svg. If svg is safe it will be uploaded else, we will show Please provide valid svg message to the user.

• Added the unit test case for the api to accept the svg.

• Snapshot:

• Before:

• After:

• In case of invalid svg(containing script tag):

Summary by CodeRabbit

• New Features

  • Added support for uploading SVG images as workspace logos with enhanced security checks for malicious code patterns.

• Tests

  • Implemented tests to ensure valid and invalid SVG uploads are correctly handled and validated.

[coderabbitai[bot]]

Walkthrough

The recent changes enhance security for SVG uploads in the AssetServiceCEImpl class by adding support for the image/svg+xml media type. A new method for validating SVG content against malicious patterns has been introduced. Additionally, two test methods in WorkspaceServiceTest ensure that both valid and invalid SVG file uploads are handled correctly, improving the robustness of the file upload functionality.

Changes

File Path	Change Summary
app/server/.../services/ce/AssetServiceCEImpl.java	Added support for image/svg+xml in allowed content types, introduced isSvgSafe method for SVG validation, and updated image type validation logic.
app/server/.../services/WorkspaceServiceTest.java	Added tests uploadWorkspaceLogo_validSvg and uploadWorkspaceLogo_invalidSvg for valid and invalid SVG uploads.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[raushan3737]

Hi @somangshu , @riteshkew: Could you please add the reviewer for this PR.

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[raushan3737]

Hi @abhvsn, @nidhi-nair, Could you please review the PR.

[nidhi-nair]

Hi @raushan3737 ! Apologies for not being able to pick up this PR for review. We're currently backed up on tasks in our backlog but we've put this PR into the backlog and will be getting to this soon. Appreciate your patience with us. 🙏🏽

[raushan3737]

Hi @nidhi-nair, Can you please review this PR if possible. It has been opened since last 2 month.

Thank you.

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[github-actions[bot]]

This PR has been closed because of inactivity.