fix:onTextChanged action gets triggered on typing numbers after 2 dec…

[prasad-madine]

Description:

In the Currency Input widget if we allow 2 decimal places and set a onTextChanged action, then on typing numbers after the 2nd decimal place the action gets triggered.

Summary by CodeRabbit

• Bug Fixes
  • Improved CurrencyInputWidget to correctly handle fractional part lengths, ensuring it respects the specified decimal places.

---

PR Type

Bug fix

---

Description

• Implemented a fix to prevent the onTextChanged action from being triggered when typing numbers after the allowed decimal places in the Currency Input widget.
• Added logic to split the input value and validate the length of the fractional part against the specified decimal places.

---

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[coderabbitai[bot]]

Walkthrough

The primary update to the CurrencyInputWidget class involves enhancing the onValueChange method to validate the length of the fractional part of the input value against the specified decimal places, ensuring the input adheres to the desired format. This update includes adjustments to the default export statement.

Changes

Files	Change Summary
app/client/src/widgets/CurrencyInputWidget/widget/index.tsx	Updated onValueChange method to validate fractional length against decimals property. Modified default export statement.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CurrencyInputWidget
    User->>CurrencyInputWidget: Types value
    CurrencyInputWidget->>CurrencyInputWidget: Calls onValueChange(value)
    CurrencyInputWidget->>CurrencyInputWidget: Validate fractional length
    CurrencyInputWidget-->>User: Display validated value or error

Poem

In the land of code, a widget bright,
For currency inputs, now just right.
Decimals check with care, precise,
Bringing user joy, oh so nice.
Export polished, neat and clean,
A coder's dream, a thoughtful scene.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[prasad-madine]

Hello @ichik @riodeuno Could you please review this PR when you have some time.

Thank you!

[ichik]

cc @KelvinOm @jsartisan

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[prasad-madine]

Hello @riodeuno Could you please review this PR when you have sometime Thankyou

[prasad-madine]

Hello @KelvinOm @jsartisan , Could you please review this PR.