appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

chore: Add worklow to check cyclic deps in a PR

Open dvj1988 opened this issue 1 year ago • 8 comments

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8968714766 Commit: 5db9cf75c7e6d9146c9347f10b48486e471f1d66 Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [ ] No

dvj1988 avatar May 06 '24 08:05 dvj1988

🔄 Cyclic Dependency Check:

You PR has more cyclic depdencies than the release branch.

github-actions[bot] avatar May 06 '24 09:05 github-actions[bot]

🔄 Cyclic Dependency Check:

You PR has more cyclic depdencies than the release branch.

Resolve any new cyclic dependencies your PR has introduced.

github-actions[bot] avatar May 06 '24 09:05 github-actions[bot]

⚠️ Cyclic Dependency Check:

You PR has more cyclic depdencies than the release branch.

Resolve any new cyclic dependencies your PR has introduced.

github-actions[bot] avatar May 06 '24 09:05 github-actions[bot]

[!WARNING]

Rate Limit Exceeded

@dvj1988 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 38 minutes and 13 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between d3ad2a1fa4033a156668cb092889033a591c5bf4 and c93f3e5df863ab7e2e287bf093a14a3f5f43e8e8.

Walkthrough

Enhancements have been made to streamline cyclic dependency management in a client application. These updates automate cyclic dependency checks via GitHub Actions, integrating them into quality assurance processes and ESLint configurations for improved development practices.

Changes

File Path Change Summary
.github/workflows/.../ci-client-cyclic-deps-check.yml Introduced a GitHub Actions workflow for checking cyclic dependencies in the client application.
.github/workflows/.../quality-checks.yml Added a job to trigger cyclic dependency checks under specific conditions.
app/client/.eslintrc.base.json Updated ESLint configuration to include the circular dependency checking script.
app/client/scripts/circular_deps_check.js Enhanced script functionality for parsing and identifying circular dependencies.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 06 '24 09:05 coderabbitai[bot]

⚠️ Cyclic Dependency Check:

This PR has increased the number of cyclic dependencies, when compared with the release branch.

Refer this document to check the cyclic dependencies.

github-actions[bot] avatar May 06 '24 09:05 github-actions[bot]

⚠️ Cyclic Dependency Check:

This PR has increased the number of cyclic dependencies, when compared with the release branch.

Refer this document to identify the cyclic dependencies introduced by this PR.

github-actions[bot] avatar May 06 '24 10:05 github-actions[bot]

@dvj1988 The cyclic deps has responded to this PR. Are these false positives?

riodeuno avatar May 06 '24 11:05 riodeuno

@dvj1988 The cyclic deps has responded to this PR. Are these false positives?

@riodeuno Ah, my bad! No its not a false positive. I reduced the number to test the comment. I have reverted it back to the correct threshold in this commit

dvj1988 avatar May 06 '24 11:05 dvj1988

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar May 20 '24 16:05 github-actions[bot]

⚠️ Cyclic Dependency Check:

This PR has increased the number of cyclic dependencies by 1, when compared with the release branch.

Refer this document to identify the cyclic dependencies introduced by this PR.

github-actions[bot] avatar May 24 '24 18:05 github-actions[bot]