appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Bug]: SSH URL pattern for private repo check does not accommodate custom port in the check

Open nidhi-nair opened this issue 1 year ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

The current pattern makes it so that the port is included as part of the path of the URL where the private repo check is made

Steps To Reproduce

Connect to a git repo on a custom port and debug through private repo check

Public Sample App

No response

Environment

Production

Severity

Low (Inconsistent UI/UX)

Issue video log

No response

Version

Cloud

nidhi-nair avatar Apr 23 '24 03:04 nidhi-nair

@brayn003 - didn't we close this?

infinitetrooper avatar Jul 22 '24 10:07 infinitetrooper

Hi @nidhi-nair, Could you please provide additional details regarding how the private repo check should ideally handle the custom port?

Sai6347 avatar Oct 17 '24 10:10 Sai6347

Hi @nidhi-nair When users attempt to connect to a GitHub private repository using a custom port, and the connection fails due to a timeout error. and in the UI we are not getting ant error message.

The URL format I provided (ssh://[email protected]:2222/shanid544/appsmith-app.git) is valid for SSH connections, but GitHub typically uses port 22 for SSH. Custom ports like 2222 may not be accepted by GitHub, leading to connection timeouts.

Currently, when a timeout occurs, users are not receiving any feedback or error messages in the UI, which can lead to confusion.

What fix we need to do on this? Should we show proper error message in the UI. or anything else, Please confirm

shanid544 avatar Oct 22 '24 05:10 shanid544

@nidhi-nair Could you please update?

shanid544 avatar Nov 07 '24 04:11 shanid544

Hi @nidhi-nair ,

I came across this issue and saw that it's labeled "Inviting Contribution". I'm a new contributor and excited to start contributing to Appsmith!

Could you please confirm if this issue is still open and if I can work on it? If there are any prerequisites or additional details I should know before starting, please let me know.

Looking forward to your guidance. Thanks! 😊

AnweshPeddineni avatar Mar 01 '25 21:03 AnweshPeddineni

Hi @nidhi-nair @brayn003 @shanid544 ,

Is this issue open/available for contribution? If yes, then I would love to contribute to the best of my efforts.

Tatwansh avatar Jun 24 '25 17:06 Tatwansh