appsmithorg
[Task]: Remove stopwatch implementation from GitFileUtils
SubTasks
- Since stopwatch only sends the metrics to logs, we haven't been able to utilise it properly. Now that the micrometer implementation is in place, we can get rid of the stopwatches from these
GitFileUtils.
Hi @sondermanish, I am unable to find GitFileUtils, can you check and let me know is this GitFileUtils or FileUtilsCEimpl, GitExecutorCEImpl and can you provide additional details for this?
Hi @sondermanish, @nidhi-nair can you please check and let me know is this GitExecutorCEImpl or not, i am unable to find the GitFileUtils?
Hi @sondermanish, @nidhi-nair is your expectation just to replace the stopwatch with micrometer to get logs or is there anything additional that needs to be done?
Hi @Sai6347 , apologies for the delay in response. Yes, the expectation is that we switch from the stopwatch implementation to micrometer, and use reactive traces where applicable. Please check references across the project of the .tap() method in reactive chains to help you get started.
Hi @Sai6347 , apologies for the delay in response. Yes, the expectation is that we switch from the stopwatch implementation to micrometer, and use reactive traces where applicable. Please check references across the project of the
.tap()method in reactive chains to help you get started.
ok nidhi, let me know is there change in the output logs after changing to micrometer
Hi @nidhi-nair, I have replaced the stopwatch with Micrometer for tracking metrics, but I’m encountering an "Access Denied" issue when trying to check the metrics due to invalid credentials. Could you share any documentation or resources on verifying and comparing these metrics with Micrometer? This would help me confirm if the integration is working correctly.
Hi @nidhi-nair , @sondermanish could you please let me know what are the credentials i need to pass here to check the metrics.
Hi @nidhi-nair , @sondermanish could you please let me know what are the credentials i need to pass here to check the metrics.
Hi @nidhi-nair , @sondermanish could you please help me out to check and verify the metrics
Hi @Sai6347! Thank you for helping out with this task.
-
Ideally we would want to remove all GitFileUtils stopwatch implementation and replace that with the micrometer observations as Nidhi already mentioned. Once that is done the timing of a call wouldn't appear on logs but where we send the observability data. In order to log that data Users need to add a few environment variables while starting the app and then they can see the data on the services that they used. I.e. Appsmith team usages new relic for this.
-
Please create a pr if you haven't created one already, and link it to this issue. I would be able to review and help you merge it.
Looking forward to facilitate your successful contribution.
GitExecutorCEImpl
ok @sondermanish i have understood that, but i have one doubt here i have changed the implementation in GitExecutorCEImpl, because i didn't find any file with GitFileUtils. can you give me clarity on it?
Hi @sondermanish , @nidhi-nair can you please assign a reviewer to this pull request
Hi @sondermanish @nidhi-nair ,
I came across this issue and saw that it's labeled "Inviting Contribution". I'm a new contributor and excited to start contributing to Appsmith!
Could you please confirm if this issue is still open and if I can work on it? If there are any prerequisites or additional details I should know before starting, please let me know.
Looking forward to your guidance. Thanks! 😊
Hello @nidhi-nair @sondermanish ,
Is this issue open for development? I can see that @Sai6347 had already created a PR for this issue, which was closed without merging it.
If it's open, please let me know. I would be happy to contribute.
