appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

feat: action creator - navigation via omnibar to side by side

Open albinAppsmith opened this issue 1 year ago • 3 comments

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Add a TL;DR when description is extra long (helps content team)

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change

Links to Notion, Figma or any other documents that might be relevant to the PR

PR fixes following issue(s)

Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [ ] Manual
  • [ ] JUnit
  • [ ] Jest
  • [ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

albinAppsmith avatar Feb 16 '24 18:02 albinAppsmith

/build-deploy-preview skip-test=true

albinAppsmith avatar Feb 16 '24 18:02 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7934633493. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 31187. recreate: .

github-actions[bot] avatar Feb 16 '24 18:02 github-actions[bot]

Deploy-Preview-URL: https://ce-31187.dp.appsmith.com

github-actions[bot] avatar Feb 16 '24 18:02 github-actions[bot]

/ok-to-test tags="@tag.All"

albinAppsmith avatar Feb 20 '24 19:02 albinAppsmith

Whoa, @tag.All spotted in your test suite! 🚀 While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️ Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja! Explore the tags documentation here

github-actions[bot] avatar Feb 20 '24 19:02 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7978720663. Workflow: Appsmith External Integration Test Workflow. Tags: ``.

github-actions[bot] avatar Feb 20 '24 19:02 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7978720663. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar Feb 20 '24 20:02 github-actions[bot]

/ok-to-test tags="@tag.All"

albinAppsmith avatar Feb 21 '24 11:02 albinAppsmith

Whoa, @tag.All spotted in your test suite! 🚀 While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️ Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja! Explore the tags documentation here

github-actions[bot] avatar Feb 21 '24 11:02 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7988192458. Workflow: Appsmith External Integration Test Workflow. Tags: ``.

github-actions[bot] avatar Feb 21 '24 11:02 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7988192458. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelector_JsToNonJSMode_2_spec.ts
  2. cypress/e2e/Regression/ClientSide/ActionExecution/ClearStore_spec.ts
  3. cypress/e2e/Regression/ClientSide/ActionExecution/Error_handling_spec.ts
  4. cypress/e2e/Regression/ClientSide/ActionExecution/FieldEvaluation_spec.ts
  5. cypress/e2e/Regression/ClientSide/ActionExecution/RemoveValue_spec.ts
  6. cypress/e2e/Regression/ClientSide/ActionExecution/StoreValue_spec.ts
  7. cypress/e2e/Regression/ClientSide/ActionExecution/uiToCode_spec.ts
  8. cypress/e2e/Regression/ClientSide/AppNavigation/AppNavigationWithAutoLayout_spec.ts
  9. cypress/e2e/Regression/ClientSide/Autocomplete/Autocomplete_setters_spec.ts
  10. cypress/e2e/Regression/ClientSide/Autocomplete/PropertyPaneSuggestion_spec.ts
  11. cypress/e2e/Regression/ClientSide/Binding/ButtonWidgets_NavigateTo_validation_spec.js
  12. cypress/e2e/Regression/ClientSide/BugTests/Binding_Bug28287_Spec.ts
  13. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
  14. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug25894_spec.ts
  15. cypress/e2e/Regression/ClientSide/BugTests/Widget_Bug27119_Spec.ts
  16. cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
  17. cypress/e2e/Regression/ClientSide/DynamicHeight/TextWidget_Spec.ts
  18. cypress/e2e/Regression/ClientSide/EmbedSettings/EmbedSettings_spec.js
  19. cypress/e2e/Regression/ClientSide/ExplorerTests/DragAndDropWidget_spec.js
  20. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
  21. cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js
  22. cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
  23. cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js
  24. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoDimension_1_spec.ts
  25. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoDimension_2_spec.ts
  26. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoHeight_Form_spec.ts
  27. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoHeight_Modal_spec.ts
  28. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionAlgorithm_AutoLayout_Validation_BasicSpec.js
  29. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/FillwidgetResizingSpec.js
  30. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/Row_Gap_spec.ts
  31. cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts
  32. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/index_spec.ts
  33. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
  34. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Replay_spec.js
  35. cypress/e2e/Regression/ClientSide/PeekOverlay/PeekOverlay_Spec.ts
  36. cypress/e2e/Regression/ClientSide/SetProperty/SetOptions_Spec.ts
  37. cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters2_spec.ts
  38. cypress/e2e/Regression/ClientSide/ThemingTests/Basic_spec.js
  39. cypress/e2e/Regression/ClientSide/ThemingTests/Theme_FormWidget_spec.js
  40. cypress/e2e/Regression/ClientSide/Widgets/Button/Button2_spec.ts
  41. cypress/e2e/Regression/ClientSide/Widgets/Button/ButtonGroup2_spec.ts
  42. cypress/e2e/Regression/ClientSide/Widgets/Button/ButtonGroup_spec.js
  43. cypress/e2e/Regression/ClientSide/Widgets/Camera/Image_Spec.ts
  44. cypress/e2e/Regression/ClientSide/Widgets/Camera/Video_Spec.ts
  45. cypress/e2e/Regression/ClientSide/Widgets/Chart/ChartWidgetErrors_spec.ts
  46. cypress/e2e/Regression/ClientSide/Widgets/Chart/Chart_widget_spec_1.ts
  47. cypress/e2e/Regression/ClientSide/Widgets/Chart/Chart_widget_spec_2.ts
  48. cypress/e2e/Regression/ClientSide/Widgets/Chart/Custom3DChartSpec.ts
  49. cypress/e2e/Regression/ClientSide/Widgets/Checkbox/CheckBoxGroupTest.ts
  50. cypress/e2e/Regression/ClientSide/Widgets/CodeScanner/CodeScanner1_spec.ts
  51. cypress/e2e/Regression/ClientSide/Widgets/CodeScanner/CodeScanner2_spec.ts
  52. cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput/CurrencyInputTest.ts
  53. cypress/e2e/Regression/ClientSide/Widgets/Datepicker/DatePicker3_spec.ts
  54. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePickerV2_CSV_spec.js
  55. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/Filepicker1_spec.js
  56. cypress/e2e/Regression/ClientSide/Widgets/Iframe/IframeTest_spec.ts
  57. cypress/e2e/Regression/ClientSide/Widgets/Image/Image2_Spec.ts
  58. cypress/e2e/Regression/ClientSide/Widgets/Image/Image3_Spec.ts
  59. cypress/e2e/Regression/ClientSide/Widgets/Input/Input2_Spec.ts
  60. cypress/e2e/Regression/ClientSide/Widgets/Input/Input3_Spec.ts
  61. cypress/e2e/Regression/ClientSide/Widgets/Input/Input_OnFocus_OnBlur_spec.js
  62. cypress/e2e/Regression/ClientSide/Widgets/Input/RTL_support.ts
  63. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_Basic_spec.js
  64. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_CurrencyField_spec.ts
  65. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Inputs_spec.js
  66. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
  67. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_spec.js
  68. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_Widget_With_Button_spec.ts
  69. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_spec.ts
  70. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect1_spec.js
  71. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect4_spec.js
  72. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect5_spec.ts
  73. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/Multi_Select_Tree_spec.js
  74. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/RTL_support.ts
  75. cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts
  76. cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_spec.js
  77. cypress/e2e/Regression/ClientSide/Widgets/Others/Progress_spec.js
  78. cypress/e2e/Regression/ClientSide/Widgets/PhoneInput/PhoneInput_Part2_spec.ts
  79. cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts
  80. cypress/e2e/Regression/ClientSide/Widgets/Rating/Rating_Widget_spec.ts
  81. cypress/e2e/Regression/ClientSide/Widgets/Select/RTL_support.ts
  82. cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts
  83. cypress/e2e/Regression/ClientSide/Widgets/Select/Select3_Spec.ts
  84. cypress/e2e/Regression/ClientSide/Widgets/Select/Select_Validation_spec.js
  85. cypress/e2e/Regression/ClientSide/Widgets/Sliders/CategorySlider_spec.ts
  86. cypress/e2e/Regression/ClientSide/Widgets/Sliders/NumberSlider_spec.ts
  87. cypress/e2e/Regression/ClientSide/Widgets/Sliders/RangeSlider_spec.ts
  88. cypress/e2e/Regression/ClientSide/Widgets/Statbox/Statbox_spec.ts
  89. cypress/e2e/Regression/ClientSide/Widgets/Switch/Switch2_spec.ts
  90. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_tabledata_schema_spec.js
  91. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Custom_column_alias_spec.js
  92. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_tabledata_schema_spec.js
  93. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select2_spec.ts
  94. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/checkboxCell_spec.js
  95. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/switchCell_spec.js
  96. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column1_spec.js
  97. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column2_spec.js
  98. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column3_spec.js
  99. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column_query_change_spec.js
  100. cypress/e2e/Regression/ClientSide/Widgets/TableV2/non_ascii_column_name_spec.js
  101. cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts
  102. cypress/e2e/Regression/ClientSide/Widgets/Text/Text2_Spec.ts
  103. cypress/e2e/Regression/ClientSide/Widgets/TreeSelect/Tree_Select_2_spec.ts
  104. cypress/e2e/Regression/ClientSide/Widgets/Video/Video_spec.ts
  105. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad2_Spec.ts
  106. cypress/e2e/Regression/ServerSide/Params/PassingParams_Spec.ts
  107. cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
  108. cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar Feb 21 '24 12:02 github-actions[bot]

POC is complete

albinAppsmith avatar Feb 23 '24 05:02 albinAppsmith