[Bug]: WDS Modal Widget issues

[riodeuno]

Is there an existing issue for this?

• [X] I have searched the existing issues

Description

Dealbreakers:

• [ ] While modal is open, when we click on the onClick handler for a child widget (Button Widget) in the property pane, the modal closes and one widget shows a crash. @riodeuno - this happens for any and all bindings on the modal widget property pane

• [ ] modal deletion behavior isssues https://www.loom.com/share/c447778f45814ce6a4a677d6f6c080a9

1. modal reopens if modal deletion + undo delete was followed by another widget's deletion and undo delete action
2. close icon is highlighted when modal deletion is undone

• [ ] There is a delay in closing the widget name component after the modal widget closes. This applies to it's child widgets too @riodeuno

• [ ] Drop indicators work differently in modal @marks0351 https://www.loom.com/share/a322171f605047eb882aa8bae6f564f9

• [ ] Modal widget cannot be opened via actions in preview and view mode. The system responds with an error when we trigger opening a modal by, for example, clicking a button widget. @riodeuno

• [ ] Modal is trimmed off on edit mode and cuts off the entire last section on preview mode

• [ ] copy-pasting using select-all method when a modal is present on canvas causes a modal copy to be inserted as well https://www.loom.com/share/1cb06c325bf841d4868cdc2814586b2f?focus_title=1&muted=1&from_recorder=1

Others:

• [ ] Auto scroll while dragging does not work inside modal. @marks0351 (Low priority)
• [ ] Widget name component doesn't adapt quickly when scrolling within a modal @riodeuno
• [ ] click on widget to scroll does not work inside modal. @riodeuno
• [ ] opening a modal through omnibar navigation highlights the modal widget and it's close icon
• [ ] copy pasting all widgets from a large set of widget does not retain order of widgets
• [ ] modal label takes a split second longer to appear on screen compared to a widget on canvas
• [ ] modal widget scroll bar does not allow for interaction on edit mode but scroll bar on canvas can be interacted with
• [ ] modal highlight is inconsistent when user is dropping widgets for the first time versus dropping them after https://www.loom.com/share/e0f52d46b14c4da6b446e47cad45a10d

Further exploration

We can go with the 1. as it seems like the more reasonable approach.

• Users can have two modal widgets open at the same time. Today, the stacking order is the order in which they're shown in the entity explorer. The solution is to make sure that the currently "selected" modal widget is at the top. However, due to the solution chosen in issue 1 above, the previously open modal will automatically close when a second modal is selected.

Done:

• [x] Modal widget gets clipped in preview and view mode @marks0351 https://github.com/appsmithorg/appsmith/assets/103687/81f491d4-f83e-41b9-a62a-1afae3ecea64

• [x] Modal selection is not consistent when opening a modal. https://github.com/appsmithorg/appsmith/assets/103687/567b6cb3-36db-480a-87d6-331366d66458

• [x] Users can select non modal widgets from the entity explorer while a modal widget is open. There are two ways to solve for this:

  • Close the modal widget if a non modal widget is selected.
  • Don't allow selecting a non modal widget if a modal widget is open

• [x] unable to see highlights at times when the modal has a scroll.

• [x] https://www.notion.so/appsmith/widget-selection-QA-52a124d2e160488396b466fb1f6464f7?pvs=4#df3cf8bbfbf346d8a524e1dbd6fb7f4d @marks0351

Steps To Reproduce

Issue 1: Select a widget on the Main canvas while a modal is open from the property pane Issue 2: Select another modal while one modal is open. Make sure that the selected modal is shown before the open modal in the entity explorer.

Public Sample App

No response

Environment

Deploy Preview

Issue video log

No response

Version

https://ce-28238.dp.appsmith.com/

[ramsaptami]

more issues: (~added to the above list so ignore this list)

• [x] https://www.loom.com/share/e0f52d46b14c4da6b446e47cad45a10d
• [x] #33205

[riodeuno]

@ramsaptami I cannot replicate this issue, would you mind sharing a screen recording?

[ramsaptami]

@riodeuno sorry, which issue specifically here?

[marks0351]

@riodeuno if you are talking about not being able to type into the widget name search while a modal is open, then its been fixed by one of my last prs. cc: @ramsaptami