appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix: Snowflake error msg fix on test datasource timeout

Open PiyushPushkar02 opened this issue 2 years ago • 5 comments

Description

  • Set a flag called InitializationFailTimeout to -1 to create the connection pool asynchronously.
  • Set the connectionTimeout value to timeout to handle any issue with the connection as the pool is getting created asynchronously now.
  • Changed the error message returned to the user for an invalid Snowflake URL.

Fixes #16140 Fixes #22035

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Junit

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

PiyushPushkar02 avatar May 12 '23 08:05 PiyushPushkar02

/ok-to-test

PiyushPushkar02 avatar May 12 '23 10:05 PiyushPushkar02

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4957641619. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23270. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23270&runId=4957641619_1

github-actions[bot] avatar May 12 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957641619. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957641619. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957641619. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 13:05 github-actions[bot]

/ok-to-test sha=3800148

PiyushPushkar02 avatar May 15 '23 05:05 PiyushPushkar02

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4976729932. Workflow: Appsmith External Integration Test Workflow. Commit: 3800148. PR: 23270. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23270&runId=4976729932_1

github-actions[bot] avatar May 15 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4976729932. Commit: 3800148. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_container_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Binary_Spec.ts
  3. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 15 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4976729932. Commit: 3800148. All cypress tests have passed 🎉

github-actions[bot] avatar May 15 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4976729932. Commit: 3800148. All cypress tests have passed 🎉

github-actions[bot] avatar May 15 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4976729932. Commit: 3800148. All cypress tests have passed 🎉

github-actions[bot] avatar May 15 '23 09:05 github-actions[bot]

/build-deploy-preview

PiyushPushkar02 avatar May 15 '23 10:05 PiyushPushkar02

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4979205980. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 23270. recreate: .

github-actions[bot] avatar May 15 '23 10:05 github-actions[bot]

Deploy-Preview-URL: https://ce-23270.dp.appsmith.com

github-actions[bot] avatar May 15 '23 10:05 github-actions[bot]