appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

feat: Adds option to fork an app within the app editor

Open rahulbarwal opened this issue 2 years ago • 22 comments

Description

  • Fork within application, this needs 2 things:
    • Load the workspaceList even when we have setModalClose variable set
    • When fork is successful, on the next page it should close the forking modal
  • Adds forking model to EditorAppName menu
  • Adds FETCH_APPLICATION_INIT to forkApplicationSaga
    • This makes sure that when we fork an app from within another app, it will reinitialize the new app properly.
  • Corrects workspaceId variable for forkApplicationSaga

PR fixes following issue(s)

Fixes # (issue number) #21470

Media

Screenshot 2023-05-10 at 11 17 44 AM 1

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

How Has This Been Tested?

  • [x] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

rahulbarwal avatar May 10 '23 04:05 rahulbarwal

/build-deploy-preview

rahulbarwal avatar May 10 '23 04:05 rahulbarwal

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4933264027. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 23158. recreate: .

github-actions[bot] avatar May 10 '23 04:05 github-actions[bot]

Deploy-Preview-URL: https://ce-23158.dp.appsmith.com

github-actions[bot] avatar May 10 '23 05:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 10 '23 08:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4934859767. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23158. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23158&runId=4934859767_1

github-actions[bot] avatar May 10 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4934859767. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_dataToTableWithSnipingMode_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/NavigateToFeatureValidation_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/TriggerErrors_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/PropertyPane/PropertyPane_Search_spec.ts
  5. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_MultiSelectWidget_spec.js
  6. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js
  7. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Button/Button_tooltip_spec.js
  8. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup_withQuery_spec.js
  9. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Filepicker/Filepicker1_spec.js
  10. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List3_spec.js
  11. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Modal/Modal_focus_spec.js
  12. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/Camera_spec.js
  13. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_FilteredTableData_spec.js
  14. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_MultiRowSelect_spec.js
  15. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_MultiRowSelect_dataUpdation_spec.js
  16. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_misc.js
  17. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  18. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Unique_name_spec.js
  19. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/CurlImportFlow_spec.js
  20. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/APIOnLoad_Spec.ts
  21. cypress/integration/SanitySuite/Datasources/MsSQLDataSourceStub_spec.js
  22. cypress/integration/SanitySuite/Datasources/MySQLNoiseTest_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 10:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 10 '23 13:05 rahulbarwal

/ok-to-test

rahulbarwal avatar May 11 '23 06:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4944682041. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23158. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23158&runId=4944682041_1

github-actions[bot] avatar May 11 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4944682041. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4944682041. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 08:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 12 '23 05:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4955413512. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23158. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23158&runId=4955413512_1

github-actions[bot] avatar May 12 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4955413512. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 06:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 12 '23 09:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4957369883. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23158. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23158&runId=4957369883_1

github-actions[bot] avatar May 12 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957369883. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957369883. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 13 '23 10:05 github-actions[bot]

@rahulbarwal - Merge latest release & trigger new oktotest. Cancelling the re-run since its past 12 hours from initial attempt.

Aishwarya-U-R avatar May 13 '23 10:05 Aishwarya-U-R

/ok-to-test

rahulbarwal avatar May 13 '23 10:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4966489038. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23158. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23158&runId=4966489038_1

github-actions[bot] avatar May 13 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4966489038. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 13 '23 12:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 15 '23 17:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4983099926. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23158. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23158&runId=4983099926_1

github-actions[bot] avatar May 15 '23 17:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4983099926. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 15 '23 18:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4983099926. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 16 '23 03:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 22 '23 11:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5045271950. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23158. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23158&runId=5045271950_1

github-actions[bot] avatar May 22 '23 11:05 github-actions[bot]

/build-deploy-preview env=release

rahulbarwal avatar May 22 '23 11:05 rahulbarwal

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5045275225. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23158. recreate: .

github-actions[bot] avatar May 22 '23 11:05 github-actions[bot]