appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

chore: add logs to capture duration for operations

Open nsarupr opened this issue 2 years ago • 3 comments

Description

The code changes in the PR are supposed to capture duration of business operation logics which are executed during the creation of user.

PR fixes following issue(s)

Fixes #22147

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

None. We are adding logs to capture duration of business operation logic.

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

nsarupr avatar May 09 '23 13:05 nsarupr

/ok-to-test sha=812195d

nsarupr avatar May 09 '23 13:05 nsarupr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4926441393. Workflow: Appsmith External Integration Test Workflow. Commit: 812195d. PR: 23140. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23140&runId=4926441393_1

github-actions[bot] avatar May 09 '23 13:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4926441393. Commit: 812195d. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 09 '23 15:05 github-actions[bot]

/ok-to-test sha=f3af0db

nsarupr avatar May 10 '23 09:05 nsarupr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4935225990. Workflow: Appsmith External Integration Test Workflow. Commit: f3af0db. PR: 23140. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23140&runId=4935225990_1

github-actions[bot] avatar May 10 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4935225990. Commit: f3af0db. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4935225990. Commit: f3af0db. All cypress tests have passed 🎉

github-actions[bot] avatar May 10 '23 11:05 github-actions[bot]