appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: CURL empty command error msg fix

Open PiyushPushkar02 opened this issue 2 years ago • 7 comments

Description

  • Changed the error message returned in case of empty input from the user for CURL import

Fixes #12008

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

PiyushPushkar02 avatar May 09 '23 09:05 PiyushPushkar02

Hi @PiyushPushkar02 , can you please add a JUnit TC for this in CurImporterServiceTests.java if possible ?

Done @sumitsum

PiyushPushkar02 avatar May 10 '23 09:05 PiyushPushkar02

/ok-to-test

PiyushPushkar02 avatar May 10 '23 09:05 PiyushPushkar02

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4935582637. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23119. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23119&runId=4935582637_1

github-actions[bot] avatar May 10 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4935582637. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Sliders/RangeSlider_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4935582637. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 10 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4935582637. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 10 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4935582637. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 10 '23 12:05 github-actions[bot]

/build-deploy-preview

PiyushPushkar02 avatar May 11 '23 06:05 PiyushPushkar02

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4944585060. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 23119. recreate: .

github-actions[bot] avatar May 11 '23 06:05 github-actions[bot]

/build-deploy-preview

PiyushPushkar02 avatar May 11 '23 07:05 PiyushPushkar02

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4945106978. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 23119. recreate: .

github-actions[bot] avatar May 11 '23 07:05 github-actions[bot]

Deploy-Preview-URL: https://ce-23119.dp.appsmith.com

github-actions[bot] avatar May 11 '23 07:05 github-actions[bot]