appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix: Open state of bottom bar

Open ChandanBalajiBP opened this issue 2 years ago • 32 comments

Description

Improved tab handling in DebuggerTabs.tsx and JSResponseView.tsx Added conditions to prevent unnecessary rendering when selecting RESPONSE_TAB or HEADER_TAB, improving performance.

Responsive ActionExecutionResizerHeight Adjusted the height calculation to be 30% of the window height, making it adaptable to different screen sizes.

Applied tab handling improvements to DataSourceEditor/Debugger Enhanced the performance of the DataSourceEditor/Debugger component by implementing similar tab handling conditions.

PR fixes following issue(s)

Fixes #22810

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [x] Manual
  • [ ] Jest
  • [x] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR testplan

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

ChandanBalajiBP avatar May 08 '23 10:05 ChandanBalajiBP

PR Summary

  • Improved tab handling in DebuggerTabs.tsx and JSResponseView.tsx Added conditions to prevent unnecessary rendering when selecting RESPONSE_TAB or HEADER_TAB, improving performance.
  • Responsive ActionExecutionResizerHeight Adjusted the height calculation to be 20% of the window height, making it adaptable to different screen sizes.
  • Applied tab handling improvements to DataSourceEditor/Debugger Enhanced the performance of the DataSourceEditor/Debugger component by implementing similar tab handling conditions.

what-the-diff[bot] avatar May 08 '23 10:05 what-the-diff[bot]

/build-deploy-preview env=release

ChandanBalajiBP avatar May 08 '23 10:05 ChandanBalajiBP

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4914159629. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23077. recreate: .

github-actions[bot] avatar May 08 '23 10:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-61xkhdg3g-get-appsmith.vercel.app

github-actions[bot] avatar May 08 '23 10:05 github-actions[bot]

/ok-to-test

ChandanBalajiBP avatar May 09 '23 14:05 ChandanBalajiBP

/build-deploy-preview env=release

ChandanBalajiBP avatar May 09 '23 14:05 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4927063331. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23077. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23077&runId=4927063331_1

github-actions[bot] avatar May 09 '23 14:05 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4927064829. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23077. recreate: .

github-actions[bot] avatar May 09 '23 14:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-lvfsb97rf-get-appsmith.vercel.app

github-actions[bot] avatar May 09 '23 14:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4927063331. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EntityBottomBar_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 09 '23 16:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4927063331. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EntityBottomBar_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 09 '23 17:05 github-actions[bot]

/ok-to-test

ChandanBalajiBP avatar May 10 '23 04:05 ChandanBalajiBP

/build-deploy-preview env=release

ChandanBalajiBP avatar May 10 '23 04:05 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4933248889. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23077. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23077&runId=4933248889_1

github-actions[bot] avatar May 10 '23 04:05 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4933249382. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23077. recreate: .

github-actions[bot] avatar May 10 '23 04:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-h6j7emy0a-get-appsmith.vercel.app

github-actions[bot] avatar May 10 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4933248889. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19982_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4933248889. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4933248889. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 10:05 github-actions[bot]

/ok-to-test

ChandanBalajiBP avatar May 10 '23 14:05 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4937895368. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23077. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23077&runId=4937895368_1

github-actions[bot] avatar May 10 '23 14:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4937895368. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_DatePicker_Text_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Promises_Spec.ts
  4. cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/ExportApplication_spec.js
  6. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  7. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Chart_spec.js
  8. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/TableFilter2_Spec.ts
  9. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2Filter2_Spec.ts
  10. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js
  11. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
  12. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 17:05 github-actions[bot]

/ok-to-test

ChandanBalajiBP avatar May 11 '23 06:05 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4944505852. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23077. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23077&runId=4944505852_1

github-actions[bot] avatar May 11 '23 06:05 github-actions[bot]

/ok-to-test

ChandanBalajiBP avatar May 11 '23 06:05 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4944590869. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23077. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23077&runId=4944590869_1

github-actions[bot] avatar May 11 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4944590869. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 07:05 github-actions[bot]

/ok-to-test

ChandanBalajiBP avatar May 11 '23 10:05 ChandanBalajiBP

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4947046874. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23077. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23077&runId=4947046874_1

github-actions[bot] avatar May 11 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4947046874. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/MongoDBShoppingCart_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 12:05 github-actions[bot]