appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Redis Error Message Fix

Open PiyushPushkar02 opened this issue 2 years ago • 6 comments

Description

  • Changed the error message returned in case of an invalid hostname for Redis.
  • This PR does not solve the issue for mongo.

Fixes #21405

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • JUnit

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

PiyushPushkar02 avatar May 08 '23 07:05 PiyushPushkar02

PR Summary

  • Changed testDatasource method return type The method now returns a Mono<DatasourceTestResult> instead of being void, which provides more information about the test results.
  • Introduced verifyPing method A new method called verifyPing is created. It returns a DatasourceTestResult and is now used in the testDataSource function for better testing accuracy.

what-the-diff[bot] avatar May 08 '23 07:05 what-the-diff[bot]

/ok-to-test sha=c82f603

PiyushPushkar02 avatar May 09 '23 08:05 PiyushPushkar02

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4923848422. Workflow: Appsmith External Integration Test Workflow. Commit: c82f603. PR: 23067. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23067&runId=4923848422_1

github-actions[bot] avatar May 09 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4923848422. Commit: c82f603. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 09 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4923848422. Commit: c82f603. All cypress tests have passed 🎉

github-actions[bot] avatar May 09 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4923848422. Commit: c82f603. All cypress tests have passed 🎉

github-actions[bot] avatar May 09 '23 11:05 github-actions[bot]

/build-deploy-preview

PiyushPushkar02 avatar May 10 '23 07:05 PiyushPushkar02

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4934264851. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 23067. recreate: .

github-actions[bot] avatar May 10 '23 07:05 github-actions[bot]

Deploy-Preview-URL: https://ce-23067.dp.appsmith.com

github-actions[bot] avatar May 10 '23 07:05 github-actions[bot]