appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Bug]: Design System - Modal - `right` attribute bound to incorrect prop

Open iamenrique opened this issue 2 years ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

The ModalComponent of the design system doesn't set the right attribute correctly. The component already supports the right attribute as a prop, but it's not bound to it (bound to bottom instead).

Steps To Reproduce

  1. Go to the file: app/client/src/components/designSystems/appsmith/ModalComponent.tsx
  2. Search for props.right. Then search for props.bottom. You'll notice the inconsistency.

Public Sample App

No response

Environment

Release

Issue video log

No response

Version

Release

iamenrique avatar May 05 '23 18:05 iamenrique

PR: https://github.com/appsmithorg/appsmith/pull/23037

iamenrique avatar May 05 '23 18:05 iamenrique

In fact also the ModalWidget/component has the exact same issue.

iamenrique avatar May 05 '23 19:05 iamenrique

@iamenrique Please take a look.

iSatVeerSingh avatar May 07 '23 05:05 iSatVeerSingh

@albinAppsmith : is this still an issue after ADS 2.0?

rohitagarwal88 avatar Jun 08 '23 12:06 rohitagarwal88