chore: poc to merge DS editor data flows
Description
POC to merge the DS editors for 3 different types of datasources
- Databases and SAAS
- G sheets
- Authenticated API and Graphql
This PR will not merge the G sheets editor since it is tied to a lot of places in testing and URL. This will be picked in another iteration.
Fixes #22860 (#1367 from EE)
Media
A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video
Type of change
- Chore (housekeeping or task changes that don't impact user perception)
How Has This Been Tested?
- Manual
- Jest
- Cypress
Test Plan
- PostGreSQL [Regression Cases to be executed]
- Mongo
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [x] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4861788032.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22920.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22920&runId=4861788032_1
Adding test plan approved label since these will require only regression. No change for user
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4861788032. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4861788032. Commit: ``. All cypress tests have passed 🎉
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4879165556.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22920.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22920&runId=4879165556_1
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4880785024.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22920.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22920&runId=4880785024_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4880785024. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiWithOAuth_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4880785024. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiWithOAuth_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4880785024. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiWithOAuth_spec.ts
/build-deploy-preview
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4935779320.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 22920.
recreate: .
/build-deploy-preview skip-tests=true
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4936098737.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 22920.
recreate: .
Deploy-Preview-URL: https://ce-22920.dp.appsmith.com
@ayushpahwa Add datasource forms are not scrollable. This is a blocker [UI] issue.
- Rest API - after running an api and then doing save as datasource - the screen that comes up is incorrect
- Graph QL - New DS - Similar issue as above is seen
- Test button seems to be missing on PostGreSQL and Mongo
/build-deploy-preview skip-tests=true
/ok-to-test
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4947390032.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 22920.
recreate: .
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4947391510.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22920.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22920&runId=4947391510_1
Deploy-Preview-URL: https://ce-22920.dp.appsmith.com
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4947391510. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/Application/CommunityIssues_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19933_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/DatasourceSchema_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Datasource_Structure_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Refactoring/Refactoring_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Styles_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/Basic_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Array_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/BooleanEnum_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Character_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/DateTime_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Json_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Numeric_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/ConfirmRunAction_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/SwitchDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/ArangoDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/Arango_Basic_Spec.ts
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiWithOAuth_spec.ts
- cypress/integration/SanitySuite/Datasources/DSAutosaveImprovements_spec.ts
- cypress/integration/SanitySuite/Datasources/GraphQL_spec.ts
- cypress/integration/SanitySuite/Datasources/MongoDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/MsSQLDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/MySQLDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/MySQL_spec.js
- cypress/integration/SanitySuite/Datasources/PostgresDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/RedshiftDataSourceStub_spec.js
- cypress/integration/SmokeSuite/Application/ReconnectDatasource_spec.js
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4950534641.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22920.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22920&runId=4950534641_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4950534641. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/Application/CommunityIssues_Spec.ts
- cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/AdminSettings/Admin_settings_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19933_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/DatasourceSchema_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Datasource_Structure_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Refactoring/Refactoring_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Styles_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/Basic_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Array_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/BooleanEnum_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Character_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/DateTime_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Json_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Numeric_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/ConfirmRunAction_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/SwitchDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/ArangoDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/Arango_Basic_Spec.ts
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiWithOAuth_spec.ts
- cypress/integration/SanitySuite/Datasources/DSAutosaveImprovements_spec.ts
- cypress/integration/SanitySuite/Datasources/GraphQL_spec.ts
- cypress/integration/SanitySuite/Datasources/MongoDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/MsSQLDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/MySQLDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/MySQL_spec.js
- cypress/integration/SanitySuite/Datasources/PostgresDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/RedshiftDataSourceStub_spec.js
- cypress/integration/SmokeSuite/Application/ReconnectDatasource_spec.js
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4950534641. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/Application/CommunityIssues_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/AdminSettings/Admin_settings_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19933_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/DatasourceSchema_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Datasource_Structure_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Refactoring/Refactoring_spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Styles_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/Basic_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Array_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/BooleanEnum_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Character_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/DateTime_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Json_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Numeric_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/ConfirmRunAction_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/SwitchDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/ArangoDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/Arango_Basic_Spec.ts
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/AuthenticatedApiWithOAuth_spec.ts
- cypress/integration/SanitySuite/Datasources/DSAutosaveImprovements_spec.ts
- cypress/integration/SanitySuite/Datasources/GraphQL_spec.ts
- cypress/integration/SanitySuite/Datasources/MongoDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/MsSQLDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/MySQLDataSourceStub_spec.js
- cypress/integration/SanitySuite/Datasources/MySQL_spec.js
- cypress/integration/SanitySuite/Datasources/PostgresDatasource_spec.js
- cypress/integration/SanitySuite/Datasources/RedshiftDataSourceStub_spec.js
- cypress/integration/SmokeSuite/Application/ReconnectDatasource_spec.js