appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

refactor: use a valid test email

Open nsarupr opened this issue 2 years ago • 5 comments

Description

Change the email used in testing to a valid email. Currently we are using api_user. Will be changing this to api_user@api_user.com

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

All the test cases need to pass.

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

nsarupr avatar May 01 '23 16:05 nsarupr

/ok-to-test sha=9c03c68

nsarupr avatar May 01 '23 16:05 nsarupr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4853004643. Workflow: Appsmith External Integration Test Workflow. Commit: 9c03c68. PR: 22884. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22884&runId=4853004643_1

github-actions[bot] avatar May 01 '23 16:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4853004643. Commit: 9c03c68. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug22281_WelcomeTour_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 01 '23 18:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4853004643. Commit: 9c03c68. All cypress tests have passed 🎉

github-actions[bot] avatar May 02 '23 03:05 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar May 09 '23 16:05 github-actions[bot]