appsmithorg
feat: Deduplicating all pages and components being used under Admin settings
Description
Deduplicating all pages and components being used under Admin settings to use the new DS components.
Media: Old - https://cjrc9tc9nt.vmaker.com/record/MqfaaC3PXjKrmHqj Latest - https://cjrc9tc9nt.vmaker.com/record/L0dhB1jufiz4Ug7g
Type of change
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
How Has This Been Tested?
- Manual
- Jest
- Cypress
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4809482515.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 21937.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4819317474.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 21937.
recreate: .
Deploy-Preview-URL: https://appsmith-fyfqm4avc-get-appsmith.vercel.app
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4819635122.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 21937.
recreate: .
Tested this PR for basic functionalities. All the findings are noted in the Notion doc below: https://www.notion.so/appsmith/f353d8c6bd664f79ad858a42010cdfc8?v=f04cde23f6424aeb9d5a6e389cd172bd&p=c6c0a2239eaf485e912c2cdb1eff469e&pm=s
@shadabbuchh I have addressed all the issues added by you. You can take a pull of this branch and re-verify.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4859255957.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 21937.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4859823076.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 21937.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4883080494.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 21937.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4904042117.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 21937.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4912255536.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 21937.
recreate: .