appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

[Task]: Create an IconName type for Icon in ds

Open tanvibhakta opened this issue 2 years ago • 5 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

SubTasks

With the new design system, we can import any remix icon, along with a bunch of custom icons. Write a type called IconName that is a subset of both these types. This will replace the IconName type that existed in ds-old.

Revert this commit when you do so, and change the imports accordingly.

tanvibhakta avatar Mar 15 '23 12:03 tanvibhakta

Revert this commit when you do so, and change the imports accordingly.

This link is broken

jayeshchoudhary avatar Mar 16 '23 21:03 jayeshchoudhary

Revert this commit when you do so, and change the imports accordingly.

could u plz update the broken link

MrDBC avatar Mar 24 '23 14:03 MrDBC

Revert this commit when you do so, and change the imports accordingly.

reminder to fix broken link

LunarisX avatar Apr 02 '23 17:04 LunarisX

the link is broken yet @tanvibhakta

Narcos101 avatar May 05 '23 10:05 Narcos101

@tanvibhakta can you assign me this?

ameeetgaikwad avatar May 05 '23 14:05 ameeetgaikwad

Can I work on this issue?

ArslanYM avatar May 17 '23 15:05 ArslanYM

Closing coz this is fixed in https://github.com/appsmithorg/appsmith/pull/22030

rohitagarwal88 avatar May 22 '23 09:05 rohitagarwal88