appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

feat: editor header UI update

Open akash-codemonk opened this issue 3 years ago • 11 comments

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes https://github.com/appsmithorg/appsmith/issues/15677

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Test Plan

UI Test Case

Issues raised during DP testing

Please find screenshots & loom videos in the comment section.

  • [ ] Search box shortcut shows different symbol from the design
  • [ ] Design conflict for the existing Share button. Please clarify if this has to be INVITE or SHARE
  • [ ] Hover height varies for different icons
  • [ ] Preview button missing from Datasource page.
  • [ ] Save failed message persists when a page is created
  • [ ] Icons of invited members not visible in nav bar
  • [ ] Missing Appsmith version & release days in Help icon

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

akash-codemonk avatar Jan 02 '23 03:01 akash-codemonk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jan 9, 2023 at 0:20AM (UTC)

vercel[bot] avatar Jan 02 '23 03:01 vercel[bot]

  • Updated the design system version to 0.0.0-beta-20221230112905
  • Changed help bar placeholder text from "Quick search & navigation" to just "Search".
  • Removed border around HelpBar when hovered over it and changed its background color from #F0F0F0 (light gray) to white (#FFF).
  • Removed the help button from editor header
  • Added a share button to the right of deploy icon in editor header
  • Moved toggle mode and realtime editors buttons to left side of save indicator (in mobile view)
  • Changed styling for all icons used in EditorHeader component, including: hamburger menu, pin/unpin entity explorer, deploy icon and save status indicators (saving/success/error). Also changed size for some icons like appsmith logo on top-left corner etc..
  • Changed the margin-right of UserImageContainer from 4px to 3px
  • Removed the first child div's margin left property and added a class profile image with negative right margin, border color white and span tag for text inside it
  • Added z index 1 to last child div which is more than 5 editors in realtimeAppEditors array
  • In ToggleModeButton component changed height of smallHeaderHeight from 35 px to 40 px as per design changes made by designer team member (https://www.figma.com/file/XZ0Qqj8Yz7J5K9v6h1ywVb/appsmith?node-id=12%3A10)

what-the-diff[bot] avatar Jan 02 '23 03:01 what-the-diff[bot]

/ok-to-test sha=7d8b6d6

akash-codemonk avatar Jan 02 '23 04:01 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3820322934. Workflow: Appsmith External Integration Test Workflow. Commit: 7d8b6d6. PR: 19414. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19414&runId=3820322934_1

github-actions[bot] avatar Jan 02 '23 04:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/Application/CommunityIssues_Spec.ts cypress/integration/Smoke_TestSuite/Application/EchoApiCMS_spec.js cypress/integration/Smoke_TestSuite/Application/MongoDBShoppingCart_spec.js cypress/integration/Smoke_TestSuite/Application/PromisesApp_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ActionExecution/ClearStore_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ActionExecution/Error_handling_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ActionExecution/NavigateTo_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ActionExecution/PostWindowMessage_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ActionExecution/RemoveValue_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ActionExecution/StoreValue_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ActionExecution/setInterval_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/BindApi_withPageload_Input_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/BindButton_Text_WithRecaptcha_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_API_with_List_Widget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_DatePicker_Text_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_JSObject_Postgress_Table_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_MultiSelect_Button_Text_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TabWidget_Input_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2TextPagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2_Widget_API_Derived_Column_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2_Widget_API_Pagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_Table_Widget_API_Derived_Column_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_Table_Widget_API_Pagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_tableApi_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_tableV2Api_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/ButtonGroup_binding_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/ButtonWidgets_NavigateTo_validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/ChartText_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/InputWidgets_NavigateTo_validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/JSObjectToInput_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/JSObjectToListWidget_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/LoadashBasic_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/MomentBasic_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/NavigateToFeatureValidation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Promises_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/SelectWidget_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/SmartSubstitutionWidgets_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/TableV2Widgets_NavigateTo_Validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/TableV2_Style_ToggleJS_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/TableWidgets_NavigateTo_Validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Table_Style_ToggleJS_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/TextTableV2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/TextTable_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Widget_loading_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Widgets_Dependancy_validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/aTobAndbToaBasic_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/xmlParser_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/AllWidgets_Reset_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Autocomplete_JS_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Autocomplete_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug15056_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug16377_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug18876_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/CatchBlock_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/InputTruncateCheck_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/InvalidURL_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/JSParse_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/MultipleOnPageLoadConfirmation_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_List_TextWidget_Spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Tab_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Text_Widget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Visibility_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_API_Pane_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_DragAndDropWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Hide_Page_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/JSEditorContextMenu_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Page_Load_Spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Pages_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/UpdateUsersName_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/FormNativeToRawTests/Mongo_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DeleteBranch_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Git_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitWithTheming/GitWithTheming_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/Canvas_Context_Property_Pane_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/Canvas_Context_Selected_Widgets_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/JSLibrary/Library_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Linting/BasicLint_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Linting/EntityPropertiesLint_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Linting/ErrorReporting_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/FirstTimeUserOnboarding_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ApplicationURL_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/EmptyCanvas_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ExportApplication_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ForkApplication_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/PageOnLoad_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/PreviewMode_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Replay_Editor_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Replay_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Unique_key_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ViewMode_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/PropertyPane/PropertyPane_Search_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/EmbedSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/GeneralSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/PageSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ThemingTests/Basic_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ThemingTests/ThemeReset_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ThemingTests/Theme_Default_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ThemingTests/Theme_FormWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ThemingTests/Theme_MultiSelectWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Audio/AudioRecorder_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Audio/audio_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/ButtonGroup_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_onClickAction_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_tooltip_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Chart/ChartDataPoint_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Chart/Chart_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Chart/Custom_Chart_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Checkbox/CheckBox_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup1_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/CodeScanner/CodeScanner_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Container_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/CurrencyInput/CurrencyInputDynamicCurrencyCode_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/CurrencyInput/CurrencyInput_ShowStepArrows_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/CurrencyInput/CurrencyInput_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker1_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePickerV2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker_Toggle_js_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker_With_Switch_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_onOptionChange_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Filepicker/FilePicker2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Filepicker/FilePickerV2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Filepicker/Filepicker1_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_With_RichTextEditor_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/Form_With_CheckBox_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Image/Image_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Input_OnFocus_OnBlur_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Input_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Inputv2_ShowStepArrows_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Inputv2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_Basic_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FormProperties_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_HiddenFields_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONFrom_Modal_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List1_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List3_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List4_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List5_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List6_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Modal_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Multiselect/MultiSelect1_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Multiselect/MultiSelect2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Multiselect/MultiSelect4_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Multiselect/MultiTreeSelect_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Multiselect/Multi_Select_Tree_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/Camera_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/Canvas_scrolling_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/Divider_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/DocumentViewer_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/IconButton_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/MapChart_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/Progress_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/Statbox_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/Video_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/PhoneInput/PhoneInputDynamicValue_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/PhoneInput/Phone_input_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/RTE/RichTextEditor_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Radio/RadioGroup1_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Radio/RadioGroup2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Radio/Radio_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Select/Select_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Select/Select_widget1_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Select/Single_Select_Tree_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Select/Tree_Select_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Select/select_Widget_Bug_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Select/select_Widget_validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Sliders/CategroySlider_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Sliders/NumberSlider_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Sliders/RangeSlider_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Switch/SwitchGroup2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Switch/Switch_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Switch/Switchgroup1_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Tab/Tab_OnEvent_Navigation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Tab/Tab_new_scenario_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Tab/Tab_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/TableBugs_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/TableFilter1_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/TableFilter2_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Button_Icon_validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Color_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Column_Resize_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Derived_Column_Data_validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_GeneralProperty_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_PropertyPane_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Widget_Add_button_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_tabledata_schema_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Add_new_row_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Custom_column_alias_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Inline_editing_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2Filter1_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2Filter2_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Button_Icon_validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Color_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Column_Resize_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Derived_Column_Data_validation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_GeneralProperty_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Property_JsonUpdate_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Widget_Add_button_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Widget_Default_Row_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_pagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_tabledata_schema_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/checkboxCell_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/menubutton_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/select_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/switchCell_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/inline_editing_validations_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/non_ascii_column_name_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/pagesize_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/virtual_row_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Text/Text_new_feature_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Text/Text_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/WidgetCopyPaste_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Widgets_Labels_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_All_Verb_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Bugs_Spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_ContextMenu_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_MultiPart_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Mustache_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Search_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datasources/DatasourceForm_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datasources/MockDBs_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Datasources/MySQLNoiseTest_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datasources/RestApiDatasource_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datasources/RestApiOAuth2Validation_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datatypes/MySQL_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Datatypes/MySQL_false_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/Fetch_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/APIOnLoad_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad1_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Params/ExecutionParams_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Params/PassingParams_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/Array_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/Binary_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/BooleanEnum_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/Character_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/DateTime_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/Json_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/Numeric_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/MySQL_Spec.ts

github-actions[bot] avatar Jan 02 '23 06:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/EmbedSettings/EmbedSettings_spec.js cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts

github-actions[bot] avatar Jan 02 '23 06:01 github-actions[bot]

@akash-codemonk Tested this DP, here are the few issues observed.

  1. Search box shortcut shows different symbol from the design image

  2. Design conflict for the existing Share button. Please clarify if this has to be INVITE or SHARE. image

  3. Hover height varies for different icons https://loom.com/share/8354fc18802145829126de041553ba31 image

  4. Preview button missing from Datasource page. image

  5. Save failed message persists when a page is created Steps to recreate: Add two pages P1 & P2 > Add few widgets in P1 (Notice Saving icon) > Turn off internet connectivity and add one more widget to P1 (Notice Save failed icon) > Turn on internet connectivity and observe Save failed message still present > Switch between P1 & P2 (Save failed icon still remains) > Create a new Blank page (Save failed icon still remains)

https://loom.com/share/2655f1ab9dd3470199a30b68baf59c34

  1. Icons of invited members not visible in nav bar image

  2. Missing Appsmith version & release day in Help icon image

shwetha-ramesh avatar Jan 03 '23 04:01 shwetha-ramesh

@akash-codemonk Tested this DP, here are the few issues observed.

  1. Search box shortcut shows different symbol from the design image

On mac we show the cmd symbol and other platforms we show Ctrl text. This works the same on release. Have fixed the additional +.

  1. Design conflict for the existing Share button. Please clarify if this has to be INVITE or SHARE. image

It is share. The design seems to have share as well.

  1. Hover height varies for different icons https://loom.com/share/8354fc18802145829126de041553ba31 image

Have fixed this. The height equals the header height.

  1. Preview button missing from Datasource page. image

Fixed according to the slack thread https://theappsmith.slack.com/archives/C02JT9CSE6L/p1672644223449029?thread_ts=1672631606.930799&cid=C02JT9CSE6L. Showing this everywhere.

  1. Save failed message persists when a page is created Steps to recreate: Add two pages P1 & P2 > Add few widgets in P1 (Notice Saving icon) > Turn off internet connectivity and add one more widget to P1 (Notice Save failed icon) > Turn on internet connectivity and observe Save failed message still present > Switch between P1 & P2 (Save failed icon still remains) > Create a new Blank page (Save failed icon still remains)

https://loom.com/share/2655f1ab9dd3470199a30b68baf59c34

I think this is expected behaviour in some ways because the widget added while being offline does not get saved after connecting. The behaviour is consistent with release. So keeping as it is. The PR just updates the design here.

  1. Icons of invited members not visible in nav bar image

So the icons are not invited users instead these are realtime editors of the app. So if two people are editing the app at the same time. You will see an icon. This feature already exists on release as well.

  1. Missing Appsmith version & release day in Help icon image

On deploy previews the version is not shown. It will be shown once it is on release. @shwetha-ramesh

akash-codemonk avatar Jan 04 '23 08:01 akash-codemonk

/ok-to-test sha=ab00726

akash-codemonk avatar Jan 04 '23 10:01 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3837300724. Workflow: Appsmith External Integration Test Workflow. Commit: ab00726. PR: 19414. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19414&runId=3837300724_1

github-actions[bot] avatar Jan 04 '23 10:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_JSObject_Postgress_Table_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Autocomplete_JS_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Tab_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/UpdateUsersName_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Linting/ErrorReporting_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ExportApplication_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/GlobalSearch_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/PreviewMode_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/EmbedSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/PageSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Multiselect/MultiSelect2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_All_Verb_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_MultiPart_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad1_Spec.ts

github-actions[bot] avatar Jan 04 '23 11:01 github-actions[bot]

/ok-to-test sha=3162bdb

akash-codemonk avatar Jan 05 '23 12:01 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3846701183. Workflow: Appsmith External Integration Test Workflow. Commit: 3162bdb. PR: 19414. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19414&runId=3846701183_1

github-actions[bot] avatar Jan 05 '23 12:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_JSObject_Postgress_Table_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Autocomplete_JS_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug19426_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Tab_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/UpdateUsersName_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ExportApplication_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/PreviewMode_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/EmbedSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/PageSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts

github-actions[bot] avatar Jan 05 '23 13:01 github-actions[bot]

/ok-to-test sha=f9de28a

akash-codemonk avatar Jan 05 '23 17:01 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3848815497. Workflow: Appsmith External Integration Test Workflow. Commit: f9de28a. PR: 19414. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19414&runId=3848815497_1

github-actions[bot] avatar Jan 05 '23 17:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Tab_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/UpdateUsersName_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/PreviewMode_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/PageSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js

github-actions[bot] avatar Jan 05 '23 18:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts

github-actions[bot] avatar Jan 05 '23 18:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Tab_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/UpdateUsersName_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/PreviewMode_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/PreviewMode_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/SettingsPane/PageSettings_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js

github-actions[bot] avatar Jan 05 '23 18:01 github-actions[bot]

The following are new failures, please fix them before merging the PR

github-actions[bot] avatar Jan 05 '23 18:01 github-actions[bot]

/ok-to-test sha=dc1a737

akash-codemonk avatar Jan 06 '23 12:01 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3855133578. Workflow: Appsmith External Integration Test Workflow. Commit: dc1a737. PR: 19414. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19414&runId=3855133578_1

github-actions[bot] avatar Jan 06 '23 12:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/Application/PromisesApp_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/ButtonGroup_binding_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/ChartText_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/JSObjectToInput_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Promises_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/TextTableV2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/CatchBlock_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_API_Pane_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_DragAndDropWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Git_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ExportApplication_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ThemingTests/Theme_FormWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Checkbox/CheckBox_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Container_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker_With_Switch_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Filepicker/FilePicker2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Input_OnFocus_OnBlur_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Migration_Spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Modal_On_Table_Filter_Pane_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/MapChart_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Sliders/NumberSlider_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Tab/Tab_new_scenario_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_MultiRowSelect_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Widget_Add_button_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Text_wrapping_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/virtual_row_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/MemberRoles_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_RequestBody_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datasources/AuthenticatedApiDatasource_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js

github-actions[bot] avatar Jan 06 '23 14:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/Application/PromisesApp_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/ButtonGroup_binding_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/ChartText_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/JSObjectToInput_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Promises_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/TextTableV2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/CatchBlock_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_API_Pane_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_DragAndDropWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Git_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ExportApplication_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ThemingTests/Theme_FormWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Checkbox/CheckBox_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Container_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker_With_Switch_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Filepicker/FilePicker2_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Input_OnFocus_OnBlur_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Migration_Spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Modal_On_Table_Filter_Pane_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Others/MapChart_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Sliders/NumberSlider_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Tab/Tab_new_scenario_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_MultiRowSelect_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Widget_Add_button_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Text_wrapping_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/virtual_row_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/MemberRoles_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_RequestBody_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datasources/AuthenticatedApiDatasource_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js

github-actions[bot] avatar Jan 06 '23 14:01 github-actions[bot]

/ok-to-test sha=c023e5c

akash-codemonk avatar Jan 09 '23 06:01 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3871197082. Workflow: Appsmith External Integration Test Workflow. Commit: c023e5c. PR: 19414. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19414&runId=3871197082_1

github-actions[bot] avatar Jan 09 '23 06:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js

github-actions[bot] avatar Jan 09 '23 07:01 github-actions[bot]

/ok-to-test sha=6d270f7

akash-codemonk avatar Jan 09 '23 07:01 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3871756517. Workflow: Appsmith External Integration Test Workflow. Commit: 6d270f7. PR: 19414. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19414&runId=3871756517_1

github-actions[bot] avatar Jan 09 '23 07:01 github-actions[bot]

/ok-to-test sha=52d7199

akash-codemonk avatar Jan 09 '23 12:01 akash-codemonk