appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: user from group leaves workspace proper error handling

Open nsarupr opened this issue 3 years ago • 4 comments

Description

Given that a User is assigned to a User group and then assigned to a workspace currently can't leave the workspace, but it gives an ugly error right now. Now we throw a meaningful error whenever such a user tries to leave workspace.

Fixes https://github.com/appsmithorg/appsmith/issues/19058

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test cases added in EE version

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

nsarupr avatar Dec 30 '22 09:12 nsarupr

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 6:53PM (UTC)

vercel[bot] avatar Dec 30 '22 09:12 vercel[bot]

/ok-to-test sha=94e6081

nsarupr avatar Dec 30 '22 09:12 nsarupr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3805907389. Workflow: Appsmith External Integration Test Workflow. Commit: 94e6081. PR: 19347. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19347&runId=3805907389_1

github-actions[bot] avatar Dec 30 '22 09:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Autocomplete_JS_spec.ts

github-actions[bot] avatar Dec 30 '22 10:12 github-actions[bot]

/ok-to-test sha=4e6931b

nsarupr avatar Jan 06 '23 18:01 nsarupr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3857663114. Workflow: Appsmith External Integration Test Workflow. Commit: 4e6931b. PR: 19347. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19347&runId=3857663114_1

github-actions[bot] avatar Jan 06 '23 18:01 github-actions[bot]