appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

feat: Multi Pane IDE

Open hetunandu opened this issue 3 years ago • 4 comments

Description

Starts work on the Multi Pane IDE that would be behind a feature flag right now. We will continue work on this behind the scenes

New shiny Multi Pane layout that will be unwrapped after a few months

Fixes #19210

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

hetunandu avatar Dec 28 '22 04:12 hetunandu

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jan 7, 2023 at 5:11AM (UTC)

vercel[bot] avatar Dec 28 '22 04:12 vercel[bot]

/ok-to-test sha=50900e5

hetunandu avatar Dec 30 '22 07:12 hetunandu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3805483301. Workflow: Appsmith External Integration Test Workflow. Commit: 50900e5. PR: 19261. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19261&runId=3805483301_1

github-actions[bot] avatar Dec 30 '22 07:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js

github-actions[bot] avatar Dec 30 '22 08:12 github-actions[bot]

/ok-to-test

hetunandu avatar Jan 06 '23 12:01 hetunandu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3855106361. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 19261. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19261&runId=3855106361_1

github-actions[bot] avatar Jan 06 '23 12:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/ImportEmptyRepo_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Connection_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DisconnectGit_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RegenerateSSHKey_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/ThemingTests/Theme_FormWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js

github-actions[bot] avatar Jan 06 '23 13:01 github-actions[bot]

/ok-to-test

hetunandu avatar Jan 07 '23 05:01 hetunandu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3860586172. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 19261. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19261&runId=3860586172_1

github-actions[bot] avatar Jan 07 '23 05:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Chart/Custom_Chart_spec.js

github-actions[bot] avatar Jan 07 '23 06:01 github-actions[bot]

Tested this DP. All the other features are working as expected.

  1. Checked for other users if changes are reflected.
  2. Checking widget d&d on all canvas size. > Widgets in 'Dekstop' size appears zoomed out (Fonts, widgets appear smaller) when compared to the rest of the canvas size
  3. Widget shadow tail is seen when widgets are moved on canvas
  4. UI on datasource and query pages have misalignments image image image image image
  5. Since these icons are not clickable, its confusing for users image
  6. When the first pane size is increased, the canvas is lost completely. https://loom.com/share/4033fe60e3054a189bb8f5282c6aee88

shwetha-ramesh avatar Jan 09 '23 08:01 shwetha-ramesh