Fix: Context switching UX issues
Description
This PR fixes some Minor UX issues on the Canvas,
- [ ] Widget entity on widget selection does not expand
- [ ] Property pane panel jitters when panel is directly open on selecting a widget.
- [ ] URL does not retain Params while restoring previous url on page change
Fixes #18827
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manual
- Cypress
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Dec 10, 2022 at 1:59PM (UTC) |
- Bug Fix: widget explorer should automatically open on widget selection
- Added isPanelProperty to PropertyControlConstants and used it in Generator, PanelPropertiesEditor and PropertyControlsGenerator
- Added forceExpand property to Entity component which will be passed from WidgetEntity when the entity needs to be expanded forcefully (for example if a new panel was added)
/ok-to-test sha=d592bc1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3657016014.
Workflow: Appsmith External Integration Test Workflow.
Commit: d592bc1.
PR: 18828.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18828&runId=3657016014_1
/ok-to-test sha=c146d3d
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3664490190.
Workflow: Appsmith External Integration Test Workflow.
Commit: c146d3d.
PR: 18828.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18828&runId=3664490190_1