appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: hide workspace menu options trigger when there are no permissions

Open berzerkeer opened this issue 3 years ago • 7 comments

Description

When the user have no access to any of the options under workspace menu options, simply hide the trigger.

Fixes #18743

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

berzerkeer avatar Dec 07 '22 07:12 berzerkeer

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 5:18AM (UTC)

vercel[bot] avatar Dec 07 '22 07:12 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 07 '22 07:12 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 07 '22 07:12 github-actions[bot]

/ok-to-test sha=34c0526

berzerkeer avatar Dec 07 '22 07:12 berzerkeer

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3636843648. Workflow: Appsmith External Integration Test Workflow. Commit: 34c0526. PR: 18742. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18742&runId=3636843648_1

github-actions[bot] avatar Dec 07 '22 07:12 github-actions[bot]

/ok-to-test sha=0597292

berzerkeer avatar Dec 07 '22 08:12 berzerkeer

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3637124914. Workflow: Appsmith External Integration Test Workflow. Commit: 0597292. PR: 18742. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18742&runId=3637124914_1

github-actions[bot] avatar Dec 07 '22 08:12 github-actions[bot]

/ok-to-test sha=91baa49

berzerkeer avatar Dec 08 '22 06:12 berzerkeer

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3645725379. Workflow: Appsmith External Integration Test Workflow. Commit: 91baa49. PR: 18742. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18742&runId=3645725379_1

github-actions[bot] avatar Dec 08 '22 06:12 github-actions[bot]

/ok-to-test sha=ddf060e

berzerkeer avatar Dec 09 '22 05:12 berzerkeer

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3654657976. Workflow: Appsmith External Integration Test Workflow. Commit: ddf060e. PR: 18742. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18742&runId=3654657976_1

github-actions[bot] avatar Dec 09 '22 05:12 github-actions[bot]