appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: fork template tracking

Open NilanshBansal opened this issue 3 years ago • 11 comments

Description

The mixpanel analytics event fork_APPLICATIONTEMPLATE was not being tracked when the user forks a template from the Add Page option, but the same event was getting tracked when the user clicks on the Templates tab and then forks it. Due to this, the mixpanel metrics were affected.

Fixes #18416

Resolution

Added code for populating the fork_APPLICATIONTEMPLATE event in the following API:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Testing Results

The fix has been tested locally and the event tracking has been tested using Segment. In the screen recording attached below, we can see the fork_APPLICATIONTEMPLATE events being tracked in both the scenarios after adding the fix.

https://user-images.githubusercontent.com/25542733/205931589-bcb47438-6300-4dbc-80be-31fc76aa1e49.mov

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

NilanshBansal avatar Dec 06 '22 14:12 NilanshBansal

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 5:34PM (UTC)

vercel[bot] avatar Dec 06 '22 14:12 vercel[bot]

/ok-to-test sha=a7025e4514020e67f5fbf507599215f5a9d27951

NilanshBansal avatar Dec 06 '22 14:12 NilanshBansal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3630416331. Workflow: Appsmith External Integration Test Workflow. Commit: a7025e4514020e67f5fbf507599215f5a9d27951. PR: 18727. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18727&runId=3630416331_1

github-actions[bot] avatar Dec 06 '22 14:12 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 07 '22 07:12 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 07 '22 08:12 github-actions[bot]

/ok-to-test sha=a7025e4514020e67f5fbf507599215f5a9d27951

NilanshBansal avatar Dec 07 '22 08:12 NilanshBansal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3636958062. Workflow: Appsmith External Integration Test Workflow. Commit: a7025e4514020e67f5fbf507599215f5a9d27951. PR: 18727. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18727&runId=3636958062_1

github-actions[bot] avatar Dec 07 '22 08:12 github-actions[bot]

/ok-to-test sha=e9388d80127f73ec6cf23f4fc15523f5fd472a79

NilanshBansal avatar Dec 07 '22 09:12 NilanshBansal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3637755265. Workflow: Appsmith External Integration Test Workflow. Commit: e9388d80127f73ec6cf23f4fc15523f5fd472a79. PR: 18727. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18727&runId=3637755265_1

github-actions[bot] avatar Dec 07 '22 09:12 github-actions[bot]

/ok-to-test sha=6f9ddbf36181e4fc9280da1a4a706588815b8eec

NilanshBansal avatar Dec 07 '22 17:12 NilanshBansal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3641308277. Workflow: Appsmith External Integration Test Workflow. Commit: 6f9ddbf36181e4fc9280da1a4a706588815b8eec. PR: 18727. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18727&runId=3641308277_1

github-actions[bot] avatar Dec 07 '22 17:12 github-actions[bot]