appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

chore: use updated table widget in onboarding

Open akash-codemonk opened this issue 3 years ago • 2 comments

Description

Updated the onboarding app to make use of the newer table widget.

Fixes https://github.com/appsmithorg/appsmith/issues/17560

Media Release which makes use of the old widget(old property pane)

release-onboarding-table

Updated app

onboarding-table

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

akash-codemonk avatar Dec 06 '22 04:12 akash-codemonk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 4:27AM (UTC)

vercel[bot] avatar Dec 06 '22 04:12 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 06 '22 04:12 github-actions[bot]

/ok-to-test sha=024a9b4

akash-codemonk avatar Dec 13 '22 05:12 akash-codemonk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3682560520. Workflow: Appsmith External Integration Test Workflow. Commit: 024a9b4. PR: 18705. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18705&runId=3682560520_1

github-actions[bot] avatar Dec 13 '22 05:12 github-actions[bot]

@hetunandu @eco-monk bumping for approval. No code change here. Onboarding imports an app which has been updated to use the new table widget.

akash-codemonk avatar Dec 14 '22 10:12 akash-codemonk