appsmithorg
fix: datasource title not editable and ctas disabled on create
Description
This fixes even more issues on create datasource flow which are missed out when fixing #18600 . This fixes cases listed in the below issue.
TL;DR Create datasource flow permission driven cta fixes.
Fixes #18644
Media https://www.loom.com/share/5555fd58ffbd44f08971acc82def770c
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manual
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Dec 2, 2022 at 3:14PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3612579310.
Workflow: Appsmith External Integration Test Workflow.
Commit: 933e0e5.
PR: 18645.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18645&runId=3612579310_1
@berzerkeer just checked the loom video attached in the description, I hope the buttons do not read as Testsssss and Savesssss like it does in the video.
@berzerkeer just checked the loom video attached in the description, I hope the buttons do not read as
TestsssssandSavessssslike it does in the video.
Haha no if it was it would've been in the file changes right . Also those changes were made in EE repo anyways. So no need to worry.