appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Removed suggestions from design system tag input

Open albinAppsmith opened this issue 3 years ago • 9 comments

Description

As part of RBAC invite modal changes, Team managers had added suggestions functionality to design system tag input component. Since this is not being used anywhere else as of now, we are keeping this inside EE itself and not in design system.

Fixes #18594

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

albinAppsmith avatar Dec 01 '22 05:12 albinAppsmith

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 11:49AM (UTC)

vercel[bot] avatar Dec 01 '22 05:12 vercel[bot]

/ok-to-test sha=9edaffc

albinAppsmith avatar Dec 01 '22 05:12 albinAppsmith

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Dec 01 '22 06:12 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3589995099. Workflow: Appsmith External Integration Test Workflow. Commit: 9edaffc. PR: 18595. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18595&runId=3589995099_1

github-actions[bot] avatar Dec 01 '22 06:12 github-actions[bot]

Tested this PR. Tag Input component is working fine in CE.

shadabbuchh avatar Dec 01 '22 11:12 shadabbuchh

/ok-to-test sha=784fd10

albinAppsmith avatar Dec 05 '22 05:12 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3617412904. Workflow: Appsmith External Integration Test Workflow. Commit: 784fd10. PR: 18595. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18595&runId=3617412904_1

github-actions[bot] avatar Dec 05 '22 06:12 github-actions[bot]

/ok-to-test sha=e8ec1d8

albinAppsmith avatar Dec 05 '22 11:12 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3619656542. Workflow: Appsmith External Integration Test Workflow. Commit: e8ec1d8. PR: 18595. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18595&runId=3619656542_1

github-actions[bot] avatar Dec 05 '22 11:12 github-actions[bot]

This change will go along with this PR - https://github.com/appsmithorg/appsmith/pull/18782

albinAppsmith avatar Dec 10 '22 05:12 albinAppsmith