appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Improved error message for google sheet insert/update empty body

Open vaibh1297 opened this issue 3 years ago • 3 comments

Description

Improved error message for google sheet insert/update empty body

Fixes #17343

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

vaibh1297 avatar Nov 29 '22 12:11 vaibh1297

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 10:10AM (UTC)

vercel[bot] avatar Nov 29 '22 12:11 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Nov 29 '22 12:11 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 50 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Nov 30 '22 06:11 vercel[bot]

/ok-to-test sha=a6eee5b

vaibh1297 avatar Dec 14 '22 08:12 vaibh1297

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3692924662. Workflow: Appsmith External Integration Test Workflow. Commit: a6eee5b. PR: 18558. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18558&runId=3692924662_1

github-actions[bot] avatar Dec 14 '22 08:12 github-actions[bot]

/ok-to-test sha=72a616d

vaibh1297 avatar Dec 20 '22 09:12 vaibh1297

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3739259043. Workflow: Appsmith External Integration Test Workflow. Commit: 72a616d. PR: 18558. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18558&runId=3739259043_1

github-actions[bot] avatar Dec 20 '22 09:12 github-actions[bot]

/ok-to-test sha=4b83e13

Aishwarya-U-R avatar Dec 20 '22 18:12 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3743089513. Workflow: Appsmith External Integration Test Workflow. Commit: 4b83e13. PR: 18558. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18558&runId=3743089513_1

github-actions[bot] avatar Dec 20 '22 18:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/ImportEmptyRepo_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Connection_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DeleteBranch_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DisconnectGit_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Merge_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RegenerateSSHKey_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RepoLimitExceededErrorModal_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitWithTheming/GitWithTheming_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js

github-actions[bot] avatar Dec 20 '22 19:12 github-actions[bot]

/ok-to-test sha=6bd51c9

vaibh1297 avatar Dec 21 '22 10:12 vaibh1297

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3748558793. Workflow: Appsmith External Integration Test Workflow. Commit: 6bd51c9. PR: 18558. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18558&runId=3748558793_1

github-actions[bot] avatar Dec 21 '22 10:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/ImportEmptyRepo_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Connection_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DisconnectGit_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Merge_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RegenerateSSHKey_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RepoLimitExceededErrorModal_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitWithTheming/GitWithTheming_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js

github-actions[bot] avatar Dec 21 '22 12:12 github-actions[bot]