appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: RestApiPlugin get request raw body fix

Open vaibh1297 opened this issue 3 years ago • 2 comments

Description

RestApiPlugin fix for accepting raw body in get request.

Fixes #12343

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Unit Tests

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

vaibh1297 avatar Nov 27 '22 08:11 vaibh1297

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 30, 2022 at 9:35AM (UTC)

vercel[bot] avatar Nov 27 '22 08:11 vercel[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Dec 04 '22 16:12 github-actions[bot]

This PR has been closed because of inactivity.

github-actions[bot] avatar Dec 11 '22 16:12 github-actions[bot]

/ok-to-test sha=2078d11

vaibh1297 avatar Dec 13 '22 07:12 vaibh1297

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3683161429. Workflow: Appsmith External Integration Test Workflow. Commit: 2078d11. PR: 18474. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18474&runId=3683161429_1

github-actions[bot] avatar Dec 13 '22 07:12 github-actions[bot]

/ok-to-test sha=7ae2e86

vaibh1297 avatar Dec 20 '22 17:12 vaibh1297

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3742788549. Workflow: Appsmith External Integration Test Workflow. Commit: 7ae2e86. PR: 18474. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18474&runId=3742788549_1

github-actions[bot] avatar Dec 20 '22 17:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js

github-actions[bot] avatar Dec 20 '22 18:12 github-actions[bot]

/ok-to-test sha=2035b42

vaibh1297 avatar Dec 30 '22 09:12 vaibh1297

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3806005073. Workflow: Appsmith External Integration Test Workflow. Commit: 2035b42. PR: 18474. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18474&runId=3806005073_1

github-actions[bot] avatar Dec 30 '22 09:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js

github-actions[bot] avatar Dec 30 '22 10:12 github-actions[bot]