appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

feat: [WIP] javascript libraries

Open arunvjn opened this issue 3 years ago • 19 comments

Description

  • Copy and paste the URL of a library of your choice into Appsmith to have the library downloaded and ready to use. This statement comes with some limitation though, and is listed below

    • The library URL that you paste should point to a valid UMD build of the library. Libraries bundled in other module definitions are disallowed.
    • Evaluations that power Appsmith, run on web worker, and the APIs on the worker are a subset of the ones you find on the main thread. Here's the list of APIs that web workers support.

  • Libraries that use APIs that are not on web worker are unsupported.

  • Additionally, libraries that rely on XMLHttpRequest are unsupported.

  • Installed libraries get autocomplete support.

  • Additionally, this comes with Appsmith's recommended libraries, which are chosen based on community feedback and popularity

Fixes #2430 Fixes #17310 Fixes #17966 Fixes #17309

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

  • [ ] https://github.com/appsmithorg/appsmith/pull/17895#issuecomment-1314782428

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

Front logo Front conversations

arunvjn avatar Oct 27 '22 06:10 arunvjn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Dec 21, 2022 at 3:08PM (UTC)

vercel[bot] avatar Oct 27 '22 06:10 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 9 seconds (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Nov 03 '22 08:11 vercel[bot]

  • [x] Clicking on + adds a scroll bar to the screen since the libraries pop-up window overflows outside the window boundary on the bottom

  • [x] Download icon needs a hover and clicked state - design change

  • [ ] List libraries alphabetically image

  • [x] When a page containing custom libraries is clone and these libraries are deleted from one page, then they get deleted from the other (cloned/original) page too - not relevant since libraries are app level entities https://www.loom.com/share/c20addfbb5264b369cb48037e8122faf

  • [ ] Hitting enter after dropping a library URL does not initiate installation - this needs to be configured

  • [x] report issue link does not work image

  • [x] Hovering over the exclamation icon changes cursor to click icon but it's not a CTA image

  • [x] Hovering over the link icon changes cursor to click icon but it's not a CTA image

  • [x] Hovering over the username icon changes cursor to click icon but it's not a CTA image

  • [ ] Error message should be cleared once link is removed from the input box image image

  • [x] Version number is clickable and leads to an empty page image

  • [x] Copying text from here incorrectly copies a second handle image image

ramsaptami avatar Nov 15 '22 05:11 ramsaptami

/ok-to-test sha=207fb36

arunvjn avatar Nov 23 '22 08:11 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3530263513. Workflow: Appsmith External Integration Test Workflow. Commit: 207fb36. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17895&runId=3530263513_1

github-actions[bot] avatar Nov 23 '22 08:11 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 8 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Nov 23 '22 08:11 vercel[bot]

/ok-to-test sha=e2af8e4

arunvjn avatar Nov 23 '22 08:11 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3530554184. Workflow: Appsmith External Integration Test Workflow. Commit: e2af8e4. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17895&runId=3530554184_1

github-actions[bot] avatar Nov 23 '22 08:11 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 40 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Nov 23 '22 09:11 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 35 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Nov 25 '22 03:11 vercel[bot]

/ok-to-test sha=6161c30

arunvjn avatar Nov 28 '22 20:11 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3568363678. Workflow: Appsmith External Integration Test Workflow. Commit: 6161c30. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17895&runId=3568363678_1

github-actions[bot] avatar Nov 28 '22 20:11 github-actions[bot]

/ok-to-test sha=2f5d6f6

arunvjn avatar Nov 28 '22 22:11 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3569142672. Workflow: Appsmith External Integration Test Workflow. Commit: 2f5d6f6. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17895&runId=3569142672_1

github-actions[bot] avatar Nov 28 '22 22:11 github-actions[bot]

/ok-to-test sha=08bde86

arunvjn avatar Nov 29 '22 04:11 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3571129271. Workflow: Appsmith External Integration Test Workflow. Commit: 08bde86. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17895&runId=3571129271_1

github-actions[bot] avatar Nov 29 '22 04:11 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 60 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Nov 30 '22 17:11 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 44 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Nov 30 '22 17:11 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 3 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Dec 06 '22 10:12 vercel[bot]

/ok-to-test sha=9a60d44

arunvjn avatar Dec 16 '22 18:12 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3715584662. Workflow: Appsmith External Integration Test Workflow. Commit: 9a60d44. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=17895&runId=3715584662_1

github-actions[bot] avatar Dec 16 '22 18:12 github-actions[bot]

/ok-to-test sha=cb23f45

arunvjn avatar Dec 16 '22 18:12 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3715787372. Workflow: Appsmith External Integration Test Workflow. Commit: cb23f45. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=17895&runId=3715787372_1

github-actions[bot] avatar Dec 16 '22 19:12 github-actions[bot]

/ok-to-test sha=d2e1ef2

arunvjn avatar Dec 17 '22 11:12 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3719817397. Workflow: Appsmith External Integration Test Workflow. Commit: d2e1ef2. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=17895&runId=3719817397_1

github-actions[bot] avatar Dec 17 '22 11:12 github-actions[bot]

/ok-to-test sha=a6c5ab8

arunvjn avatar Dec 17 '22 18:12 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3721222328. Workflow: Appsmith External Integration Test Workflow. Commit: a6c5ab8. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=17895&runId=3721222328_1

github-actions[bot] avatar Dec 17 '22 18:12 github-actions[bot]

/ok-to-test sha=e0e95fe

arunvjn avatar Dec 18 '22 04:12 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3723185104. Workflow: Appsmith External Integration Test Workflow. Commit: e0e95fe. PR: 17895. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=17895&runId=3723185104_1

github-actions[bot] avatar Dec 18 '22 04:12 github-actions[bot]

/ok-to-test sha=6c85b78

arunvjn avatar Dec 18 '22 09:12 arunvjn