appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

feat: Clear store values

Open gitstart opened this issue 3 years ago • 5 comments

Description

At the moment developer can add to store & update store

This Implementation is to allow developer

  • Clear all store value
  • Clear specifics value from store

Fixes https://github.com/appsmithorg/appsmith/issues/11639

Type of change

  • New feature (non-breaking change which adds functionality)

gitstart avatar Oct 14 '22 17:10 gitstart

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

welcome[bot] avatar Oct 14 '22 17:10 welcome[bot]

@gitstart-appsmith is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 14 '22 17:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 5:11PM (UTC)

vercel[bot] avatar Oct 14 '22 17:10 vercel[bot]

/ok-to-test sha=ad649e9

somangshu avatar Oct 18 '22 12:10 somangshu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3273847356. Workflow: Appsmith External Integration Test Workflow. Commit: ad649e9. PR: 17568. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17568&runId=3273847356_1

github-actions[bot] avatar Oct 18 '22 14:10 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Oct 27 '22 16:10 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 1 hour (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Oct 31 '22 14:10 vercel[bot]

/ok-to-test sha=f28d764

rimildeyjsr avatar Oct 31 '22 14:10 rimildeyjsr

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3362189547. Workflow: Appsmith External Integration Test Workflow. Commit: f28d764. PR: 17568. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17568&runId=3362189547_1

github-actions[bot] avatar Oct 31 '22 14:10 github-actions[bot]

LGTM, can be merged to release

ramsaptami avatar Oct 31 '22 17:10 ramsaptami

@rimildeyjsr can you share an example usage for both the new functions? Can they be used directly or with appsmith. accessor? If usage is direct, then removeValue may need a better naming, because every other function that is to do with the store has the word store used somewhere, and this would be the only exception. cc @bharath31

rohan-arthur avatar Nov 21 '22 06:11 rohan-arthur

@rohan-arthur The naming convention implemented by the contributor follows MDN norms, i.e. does not deviate from the regular Javascript way which has previously caused us some trouble.

ramsaptami avatar Nov 21 '22 06:11 ramsaptami