appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix: MultiSelect/TreeSelect widget deselects on clicking again

Open jsartisan opened this issue 3 years ago • 10 comments

Description

This PR fixes deselecting of select widget on clicking it again.

Fixes #16948

Type of change

  • Bug fix

How Has This Been Tested?

  • Manually test

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

jsartisan avatar Oct 13 '22 06:10 jsartisan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 5:48PM (UTC)

vercel[bot] avatar Oct 13 '22 06:10 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 13 '22 06:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 13 '22 06:10 github-actions[bot]

/ok-to-test sha=a9bd089

jsartisan avatar Oct 19 '22 07:10 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3279928927. Workflow: Appsmith External Integration Test Workflow. Commit: a9bd089. PR: 17530. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17530&runId=3279928927_1

github-actions[bot] avatar Oct 19 '22 08:10 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Oct 20 '22 10:10 github-actions[bot]

/ok-to-test sha=464ca70

jsartisan avatar Oct 20 '22 11:10 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3289452916. Workflow: Appsmith External Integration Test Workflow. Commit: 464ca70. PR: 17530. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17530&runId=3289452916_1

github-actions[bot] avatar Oct 20 '22 12:10 github-actions[bot]

/ok-to-test sha=aa9c2ea

jsartisan avatar Oct 20 '22 17:10 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3291756490. Workflow: Appsmith External Integration Test Workflow. Commit: aa9c2ea. PR: 17530. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17530&runId=3291756490_1

github-actions[bot] avatar Oct 20 '22 17:10 github-actions[bot]