appsmithorg
feat: Ability to add new row in Table widget
Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.
Description
Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
if no issue exists, please create an issue and ask the maintainers about this first
Type of change
Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.
- Test A
- Test B
Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Nov 4, 2022 at 2:32PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Unable to find test scripts. Please add necessary tests to the PR.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3327905156.
Workflow: Appsmith External Integration Test Workflow.
Commit: b054182.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3327905156_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3343125210.
Workflow: Appsmith External Integration Test Workflow.
Commit: 387f3c8.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3343125210_1
Issues observed:
Issue 1 : Add new row link is NOT disabled during the inline editing flow Loom --> https://www.loom.com/share/07f153726543464f859aea0d6d2d983c Issue 2: after scrolling to the last data of the table ,can we scroll to the top to the selected row (on click of ADD NEW ROW )? Loom--> https://www.loom.com/share/9e902957d151471aa1aab7963b5a916b Issue 3: isNewRow variable doesn't work when we have empty string Loom-->https://www.loom.com/share/f759b5237dac413aa08162f360ec8a87 Issue 4: Issue with Pagination when we click on discard.(with server side pagination)(Similar pagination issue you can observe with Save action as well if you fail to ADD Query run binding onSuccess) Loom -->https://www.loom.com/share/62f40507043f40b0b323aa356b9f1053 @sbalaji1192 Lmk if more details are required
Issue 4: After clicking Save action on the add new row, it takes a while to execute the query , You can notice in that time, discard is also enabled.
Loom--> https://www.loom.com/share/5d810e216ebe438da1cbcacd09a63c42
Issue 5: Fix alignment of the icons in the table header
Attachment--> 
@kamakshibhat-appsmith Have fixed all the issues except #3 - Expected behavior. We treat the empty string as a valid value if the required field is not enabled.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3374943526.
Workflow: Appsmith External Integration Test Workflow.
Commit: f3558af.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3374943526_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3376986950.
Workflow: Appsmith External Integration Test Workflow.
Commit: d71e587.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3376986950_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3383176142.
Workflow: Appsmith External Integration Test Workflow.
Commit: 53354d0.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3383176142_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3384975264.
Workflow: Appsmith External Integration Test Workflow.
Commit: d40f77d.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3384975264_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3398567971.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7b090f2.
PR: 17515.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=17515&runId=3398567971_1