appsmithorg
fix: JS toggle default value is wrong for vertical alignment table widget
Description
- Fixes wrong default value for Vertical Alignment in column settings of table widget
- Fixes issue where JS toggle for vertical alignment cannot be turned off after turning it on once
Fixes #14953
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manually tested
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Sep 29, 2022 at 0:51AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3052583258.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3fdc92a.
PR: 16733.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3052583258.
Commit: ``.
Results: Click to view performance test results
| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 361.18 | 390.03 | 347.97 | 331.14 | 336.61 | 331.14| 347.97| 353.39 | 16.66| 6.65 | 5.95| | painting | 6.26 | 10.94 | 3.71 | 5.74 | 3.85 | 3.71| 5.74| 6.1 | 118.52| 48.03 | 42.95| | rendering | 107.92 | 114.5 | 107.76 | 108.94 | 107.41 | 107.41| 107.92| 109.31 | 6.49| 2.71 | 2.42| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 984.85 | 1735.01 | 1052.89 | 952.95 | 1150.7 | 952.95| 1052.89| 1175.28 | 66.54| 27.39 | 24.50| | painting | 23.16 | 19.82 | 25.41 | 15.71 | 34.7 | 15.71| 23.16| 23.76 | 79.92| 30.01 | 26.81| | rendering | 850.56 | 522.2 | 867.75 | 857.84 | 976.69 | 522.2| 857.84| 815.01 | 55.76| 21.05 | 18.83| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 850.4 | 964.14 | 886.44 | 850.39 | 961.6 | 850.39| 886.44| 902.59 | 12.60| 6.31 | 5.64| | painting | 9.65 | 29.7 | 13.41 | 9.43 | 10.94 | 9.43| 10.94| 14.63 | 138.55| 58.58 | 52.43| | rendering | 307.01 | 327.64 | 311.04 | 300.95 | 326.66 | 300.95| 311.04| 314.66 | 8.48| 3.80 | 3.40| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1356.76 | 1512.38 | 1338.7 | 1195.64 | 1306.45 | 1195.64| 1338.7| 1341.99 | 23.60| 8.49 | 7.59| | painting | 17.26 | 19.22 | 17.11 | 13.4 | 16.36 | 13.4| 17.11| 16.67 | 34.91| 12.66 | 11.34| | rendering | 465.99 | 509.13 | 474.1 | 452.33 | 488.62 | 452.33| 474.1| 478.03 | 11.88| 4.56 | 4.08| OPEN_MODAL| | | | | | | | | | | | scripting | 474.39 | 493.28 | 443.2 | 432.03 | 428.72 | 428.72| 443.2| 454.32 | 14.21| 6.22 | 5.56| | painting | 11.75 | 14.42 | 12.91 | 7.32 | 17.45 | 7.32| 12.91| 12.77 | 79.33| 29.13 | 26.08| | rendering | 391.68 | 439.98 | 387.76 | 364.89 | 380.59 | 364.89| 387.76| 392.98 | 19.11| 7.18 | 6.42| CLOSE_MODAL| | | | | | | | | | | | scripting | 273.44 | 195.71 | 180.45 | 189.86 | 188.67 | 180.45| 189.86| 205.63 | 45.22| 18.63 | 16.66| | painting | 7 | 11.51 | 4.97 | 14.26 | 6.49 | 4.97| 7| 8.85 | 104.97| 43.95 | 39.32| | rendering | 370.7 | 368.06 | 334.79 | 361.65 | 358.03 | 334.79| 361.65| 358.65 | 10.01| 3.97 | 3.55| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 1000.14 | 1000.24 | 898.16 | 1027.64 | 988.16 | 898.16| 1000.14| 982.87 | 13.17| 5.04 | 4.51| | painting | 8.61 | 7.06 | 5.34 | 16.36 | 6.39 | 5.34| 7.06| 8.75 | 125.94| 50.51 | 45.14| | rendering | 668.34 | 661.41 | 589.25 | 719.08 | 632.91 | 589.25| 661.41| 654.2 | 19.85| 7.30 | 6.53| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 169.6 | 168.36 | 154.26 | 175.72 | 154.18 | 154.18| 168.36| 164.42 | 13.10| 5.91 | 5.29| | painting | 6.8 | 7.43 | 6.65 | 11.43 | 2.85 | 2.85| 6.8| 7.03 | 122.05| 43.39 | 38.83| | rendering | 365.09 | 316.23 | 341.97 | 321.17 | 317.4 | 316.23| 321.17| 332.37 | 14.70| 6.33 | 5.67|
@souma-ghosh On changing the alignment and turning off the JS toggle, the respective option isn’t seen to be selected. Can you please check this? https://www.loom.com/share/74bc98b245ac46beaf4de094f24f0266
@souma-ghosh On changing the alignment and turning off the JS toggle, the respective option isn’t seen to be selected. Can you please check this? https://www.loom.com/share/74bc98b245ac46beaf4de094f24f0266
@laveena-en We can create a separate issue for this. Confirmed with @aswathkk that this is a bug we need to fix. For this PR we can go ahead if:
- Default value is correct for vertical alignment
- Able to turn off JS toggle for Vertical Alignment after its turned on
Yes, will raise a separate issue for the same @souma-ghosh PR works as expected.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3066922350.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4da23de.
PR: 16733.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3066922350.
Commit: ``.
Results: Click to view performance test results
| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 349.8 | 383.49 | 599.72 | 366.62 | 316.85 | 316.85| 366.62| 403.3 | 70.14| 27.90 | 24.96| | painting | 3.4 | 10.56 | 8.04 | 5.18 | 3 | 3| 5.18| 6.04 | 125.17| 53.31 | 47.68| | rendering | 107.21 | 109.56 | 170.25 | 116.51 | 101.7 | 101.7| 109.56| 121.05 | 56.63| 23.14 | 20.70| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1025.21 | 1015.33 | 1841.14 | 1141.55 | 963.63 | 963.63| 1025.21| 1197.37 | 73.29| 30.54 | 27.32| | painting | 20.56 | 16.07 | 32.84 | 27.19 | 16.43 | 16.07| 20.56| 22.62 | 74.14| 32.10 | 28.69| | rendering | 826.1 | 832.54 | 929.85 | 893.73 | 793.72 | 793.72| 832.54| 855.19 | 15.92| 6.46 | 5.78| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 846.35 | 981.97 | 1728.25 | 1035.36 | 851.62 | 846.35| 981.97| 1088.71 | 81.00| 33.69 | 30.14| | painting | 13.05 | 22.53 | 16.16 | 21.18 | 11.78 | 11.78| 16.16| 16.94 | 63.46| 28.28 | 25.27| | rendering | 296.52 | 306.66 | 604.9 | 333.52 | 290.41 | 290.41| 306.66| 366.4 | 85.83| 36.66 | 32.79| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1364.51 | 1406.56 | 1725.41 | 1558.8 | 1164.96 | 1164.96| 1406.56| 1444.05 | 38.81| 14.61 | 13.06| | painting | 15.11 | 16.75 | 20.9 | 23.26 | 12.89 | 12.89| 16.75| 17.78 | 58.32| 23.85 | 21.32| | rendering | 478.09 | 476.73 | 500.3 | 505.9 | 441.43 | 441.43| 478.09| 480.49 | 13.42| 5.29 | 4.73| OPEN_MODAL| | | | | | | | | | | | scripting | 505.04 | 509.97 | 575.31 | 486.77 | 413.77 | 413.77| 505.04| 498.17 | 32.43| 11.61 | 10.39| | painting | 14.17 | 9.91 | 21.6 | 13.12 | 17.62 | 9.91| 14.17| 15.28 | 76.51| 29.32 | 26.18| | rendering | 401.46 | 400.19 | 441.51 | 409.54 | 353.69 | 353.69| 401.46| 401.28 | 21.88| 7.83 | 7.01| CLOSE_MODAL| | | | | | | | | | | | scripting | 200.6 | 182.32 | 213.55 | 239.95 | 208.49 | 182.32| 208.49| 208.98 | 27.58| 10.04 | 8.98| | painting | 13.09 | 16.37 | 5.69 | 5.15 | 4.41 | 4.41| 5.69| 8.94 | 133.78| 60.74 | 54.36| | rendering | 357.08 | 339.61 | 361.76 | 360.22 | 355.43 | 339.61| 357.08| 354.82 | 6.24| 2.50 | 2.23| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 1007.86 | 989.48 | 1045.54 | 1008.14 | 942.47 | 942.47| 1007.86| 998.7 | 10.32| 3.75 | 3.36| | painting | 9.01 | 7.16 | 6.16 | 7.68 | 5.78 | 5.78| 7.16| 7.16 | 45.11| 17.88 | 16.06| | rendering | 624.16 | 639.59 | 653.09 | 606.6 | 583.49 | 583.49| 624.16| 621.39 | 11.20| 4.41 | 3.94| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 167.37 | 172.11 | 208.83 | 162.19 | 156.95 | 156.95| 167.37| 173.49 | 29.90| 11.85 | 10.59| | painting | 2.22 | 3.36 | 3.65 | 3.81 | 4.99 | 2.22| 3.65| 3.61 | 76.73| 27.42 | 24.65| | rendering | 315.59 | 334.58 | 336.06 | 309.63 | 309.59 | 309.59| 315.59| 321.09 | 8.24| 4.12 | 3.68|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3081019900.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4da23de.
PR: 16733.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3087534175.
Workflow: Appsmith External Integration Test Workflow.
Commit: da0718a.
PR: 16733.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3087534175.
Commit: ``.
Results: Click to view performance test results
| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 356.53 | 333.6 | 324.76 | 333.4 | 354.27 | 324.76| 333.6| 340.51 | 9.33| 4.13 | 3.70| | painting | 5.1 | 4.16 | 6.12 | 3.08 | 3.43 | 3.08| 4.16| 4.38 | 69.41| 28.31 | 25.34| | rendering | 101.19 | 106.42 | 103.51 | 103.75 | 102.05 | 101.19| 103.51| 103.38 | 5.06| 1.93 | 1.73| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1166.63 | 1129.47 | 1025.91 | 1057.57 | 1057.03 | 1025.91| 1057.57| 1087.32 | 12.94| 5.37 | 4.80| | painting | 15.42 | 14.18 | 11.88 | 18.44 | 13.94 | 11.88| 14.18| 14.77 | 44.41| 16.32 | 14.62| | rendering | 789.55 | 793.13 | 769.15 | 777.81 | 791.62 | 769.15| 789.55| 784.25 | 3.06| 1.32 | 1.18| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 1088.3 | 822.74 | 839.1 | 892.9 | 874.52 | 822.74| 874.52| 903.51 | 29.39| 11.84 | 10.59| | painting | 8.9 | 10.74 | 11.51 | 8.46 | 11.69 | 8.46| 10.74| 10.26 | 31.48| 14.52 | 13.06| | rendering | 289.73 | 289.44 | 288.36 | 321.73 | 297.21 | 288.36| 289.73| 297.29 | 11.22| 4.75 | 4.25| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 1366.4 | 1811.69 | 1188.28 | 1313.02 | 1335.42 | 1188.28| 1335.42| 1402.96 | 44.44| 16.98 | 15.19| | painting | 13.19 | 12.39 | 12.15 | 12.51 | 16.59 | 12.15| 12.51| 13.37 | 33.21| 13.76 | 12.34| | rendering | 440.64 | 455.87 | 423.15 | 449.26 | 450.3 | 423.15| 449.26| 443.84 | 7.37| 2.88 | 2.58| OPEN_MODAL| | | | | | | | | | | | scripting | 409.61 | 412.87 | 414.93 | 409.17 | 434.61 | 409.17| 412.87| 416.24 | 6.11| 2.53 | 2.27| | painting | 7.58 | 19.94 | 7.14 | 13.17 | 28.3 | 7.14| 13.17| 15.23 | 138.94| 58.83 | 52.66| | rendering | 367.58 | 367.31 | 372.2 | 355.26 | 373.64 | 355.26| 367.58| 367.2 | 5.01| 1.97 | 1.76| CLOSE_MODAL| | | | | | | | | | | | scripting | 210.79 | 168.96 | 167.88 | 162.64 | 157.76 | 157.76| 167.88| 173.61 | 30.55| 12.25 | 10.96| | painting | 11.31 | 11.77 | 9.96 | 9.15 | 12.68 | 9.15| 11.31| 10.97 | 32.18| 12.94 | 11.58| | rendering | 334.12 | 332.46 | 327.73 | 320.44 | 325.35 | 320.44| 327.73| 328.02 | 4.17| 1.68 | 1.50| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 922.27 | 934.37 | 930.46 | 922.32 | 922 | 922| 922.32| 926.28 | 1.34| 0.62 | 0.56| | painting | 4.83 | 10.98 | 4.67 | 6.9 | 5.56 | 4.67| 5.56| 6.59 | 95.75| 39.61 | 35.36| | rendering | 580.22 | 594.33 | 577.1 | 597.01 | 584.45 | 577.1| 584.45| 586.62 | 3.39| 1.48 | 1.33| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 150.09 | 164.02 | 160.82 | 147.87 | 158.61 | 147.87| 158.61| 156.28 | 10.33| 4.47 | 3.99| | painting | 5.29 | 2.17 | 3.64 | 4.12 | 2.64 | 2.17| 3.64| 3.57 | 87.39| 34.45 | 30.81| | rendering | 294.56 | 305.72 | 306.18 | 293.34 | 305.93 | 293.34| 305.72| 301.15 | 4.26| 2.19 | 1.96|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3099070875.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3619917.
PR: 16733.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3099070875.
Commit: ``.
Results: Click to view performance test results
| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 781.11 | 384.17 | 378.07 | 334.08 | 376.67 | 334.08| 378.07| 450.82 | 99.16| 41.19 | 36.84| | painting | 6.49 | 3.38 | 3.85 | 10.75 | 3.64 | 3.38| 3.85| 5.62 | 131.14| 55.69 | 49.82| | rendering | 205.69 | 113.56 | 130.69 | 107.64 | 105.04 | 105.04| 113.56| 132.52 | 75.95| 31.77 | 28.42| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 2095.84 | 1086.59 | 1147.35 | 1056.55 | 1089.51 | 1056.55| 1089.51| 1295.17 | 80.24| 34.65 | 30.99| | painting | 34.95 | 23.49 | 24.17 | 18.68 | 12.25 | 12.25| 23.49| 22.71 | 99.96| 36.72 | 32.85| | rendering | 788.45 | 886.78 | 923.78 | 837.81 | 814.59 | 788.45| 837.81| 850.28 | 15.92| 6.44 | 5.76| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 1788.93 | 976.36 | 958.57 | 901.55 | 992.52 | 901.55| 976.36| 1123.59 | 78.98| 33.24 | 29.73| | painting | 21.46 | 9.53 | 21.79 | 9.13 | 10.25 | 9.13| 10.25| 14.43 | 87.73| 45.60 | 40.75| | rendering | 540.33 | 307.6 | 311.28 | 313.41 | 305.57 | 305.57| 311.28| 355.64 | 66.01| 29.04 | 25.98| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 2911.79 | 1519.76 | 1446.9 | 1335.53 | 1468.4 | 1335.53| 1468.4| 1736.48 | 90.77| 38.03 | 34.02| | painting | 33.3 | 26.81 | 15.82 | 22.54 | 18.55 | 15.82| 22.54| 23.4 | 74.70| 29.57 | 26.45| | rendering | 945.16 | 523.97 | 475.39 | 458.54 | 472.74 | 458.54| 475.39| 575.16 | 84.61| 36.22 | 32.39| OPEN_MODAL| | | | | | | | | | | | scripting | 848.75 | 451.06 | 861.92 | 497.6 | 486.56 | 451.06| 497.6| 629.18 | 65.30| 32.93 | 29.46| | painting | 24.66 | 8.82 | 16.05 | 9.91 | 8.88 | 8.82| 9.91| 13.66 | 115.96| 50.07 | 44.80| | rendering | 569.52 | 386.54 | 391.76 | 431.77 | 404.21 | 386.54| 404.21| 436.76 | 41.89| 17.46 | 15.61| CLOSE_MODAL| | | | | | | | | | | | scripting | 396.69 | 671.18 | 202.09 | 238.69 | 241.71 | 202.09| 241.71| 350.07 | 134.00| 55.56 | 49.70| | painting | 11.11 | 4.45 | 4.62 | 9.14 | 4.42 | 4.42| 4.62| 6.75 | 99.11| 46.81 | 41.93| | rendering | 681.93 | 339.21 | 372.08 | 345.14 | 352.51 | 339.21| 352.51| 418.17 | 81.96| 35.38 | 31.65| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 1111.02 | 1048.16 | 943.64 | 1007.41 | 950.75 | 943.64| 1007.41| 1012.2 | 16.54| 6.91 | 6.18| | painting | 15.34 | 13.01 | 6.39 | 5.47 | 6.17 | 5.47| 6.39| 9.28 | 106.36| 49.14 | 43.97| | rendering | 696.04 | 633.5 | 635.63 | 610.57 | 615.23 | 610.57| 633.5| 638.19 | 13.39| 5.35 | 4.79| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 204.83 | 173.55 | 173.57 | 181 | 156.47 | 156.47| 173.57| 177.88 | 27.19| 9.87 | 8.83| | painting | 6.71 | 8.13 | 5.8 | 9.96 | 3.89 | 3.89| 6.71| 6.9 | 87.97| 33.33 | 29.86| | rendering | 399.18 | 318.98 | 308.18 | 332.43 | 307.76 | 307.76| 318.98| 333.31 | 27.43| 11.45 | 10.24|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3110698418.
Workflow: Appsmith External Integration Test Workflow.
Commit: bacad19.
PR: 16733.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3110698418.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 412.26 | 365.69 | 348.75 | 454.44 | 334.13 | 334.13 | 365.69 | 383.05 | 31.41 | 12.94 | 11.57 |
| painting | 3.74 | 3.24 | 2.97 | 7.89 | 3.29 | 2.97 | 3.29 | 4.23 | 116.31 | 48.94 | 43.74 |
| rendering | 112.4 | 107.5 | 109.2 | 115.27 | 107.01 | 107.01 | 109.2 | 110.28 | 7.49 | 3.17 | 2.84 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 1048.54 | 1202.9 | 1104.55 | 1135.62 | 1056.25 | 1048.54 | 1104.55 | 1109.57 | 13.91 | 5.70 | 5.10 |
| painting | 19 | 17.98 | 17.47 | 25.87 | 21.54 | 17.47 | 19 | 20.37 | 41.24 | 16.94 | 15.17 |
| rendering | 894.22 | 803.46 | 849.01 | 883.03 | 792.64 | 792.64 | 849.01 | 844.47 | 12.03 | 5.41 | 4.84 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 938.22 | 883.59 | 942.88 | 1110.26 | 908.9 | 883.59 | 938.22 | 956.77 | 23.69 | 9.31 | 8.33 |
| painting | 19.21 | 15.13 | 11.59 | 13.78 | 14.78 | 11.59 | 14.78 | 14.9 | 51.14 | 18.66 | 16.64 |
| rendering | 326.88 | 295.4 | 303.02 | 340.92 | 299.89 | 295.4 | 303.02 | 313.22 | 14.53 | 6.29 | 5.63 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 1687.91 | 1357.53 | 1717.78 | 1837.69 | 1428.86 | 1357.53 | 1687.91 | 1605.95 | 29.90 | 12.69 | 11.35 |
| painting | 15.92 | 11.89 | 22.27 | 18.3 | 19.62 | 11.89 | 18.3 | 17.6 | 58.98 | 22.33 | 20.00 |
| rendering | 490.87 | 440.21 | 510.09 | 549.78 | 476.72 | 440.21 | 490.87 | 493.53 | 22.20 | 8.21 | 7.35 |
| OPEN_MODAL | |||||||||||
| scripting | 497.55 | 431.95 | 655.71 | 622.85 | 481.71 | 431.95 | 497.55 | 537.95 | 41.59 | 17.91 | 16.01 |
| painting | 11.47 | 15.9 | 12.85 | 25.44 | 16.47 | 11.47 | 15.9 | 16.43 | 85.03 | 33.17 | 29.70 |
| rendering | 400.91 | 358.08 | 462.73 | 482.02 | 364.42 | 358.08 | 400.91 | 413.63 | 29.96 | 13.65 | 12.21 |
| CLOSE_MODAL | |||||||||||
| scripting | 214.2 | 185.82 | 193.66 | 226.69 | 252.54 | 185.82 | 214.2 | 214.58 | 31.09 | 12.44 | 11.13 |
| painting | 6.76 | 25.43 | 4.49 | 5.34 | 8.81 | 4.49 | 6.76 | 10.17 | 205.90 | 85.45 | 76.40 |
| rendering | 355.74 | 345.11 | 352.86 | 382.74 | 342.42 | 342.42 | 352.86 | 355.77 | 11.33 | 4.51 | 4.03 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 959.17 | 948.13 | 1103.08 | 943.22 | 938.72 | 938.72 | 948.13 | 978.46 | 16.80 | 7.16 | 6.41 |
| painting | 10.29 | 6.43 | 13.44 | 5.61 | 6.63 | 5.61 | 6.63 | 8.48 | 92.33 | 39.03 | 34.91 |
| rendering | 597.17 | 596.25 | 733.47 | 600.01 | 625.5 | 596.25 | 600.01 | 630.48 | 21.76 | 9.33 | 8.34 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 245.33 | 154.66 | 200.44 | 175.57 | 158.11 | 154.66 | 175.57 | 186.82 | 48.53 | 20.02 | 17.90 |
| painting | 8.4 | 2.08 | 10.36 | 7.8 | 3.22 | 2.08 | 7.8 | 6.37 | 129.98 | 55.73 | 49.92 |
| rendering | 311.74 | 350.69 | 378.07 | 304.08 | 303.03 | 303.03 | 311.74 | 329.52 | 22.77 | 10.15 | 9.07 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3112203928.
Workflow: Appsmith External Integration Test Workflow.
Commit: c31c5cb.
PR: 16733.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3112203928.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 488.42 | 1239.2 | 382.93 | 1083.67 | 427.13 | 382.93 | 488.42 | 724.27 | 118.23 | 55.86 | 49.96 |
| painting | 4.42 | 5.37 | 5.81 | 4.23 | 5.67 | 4.23 | 5.37 | 5.1 | 30.98 | 14.31 | 12.75 |
| rendering | 155.44 | 127.98 | 108.78 | 105.36 | 115.71 | 105.36 | 115.71 | 122.65 | 40.83 | 16.53 | 14.78 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 1650.83 | 1168.81 | 1132.54 | 1040.8 | 1053.99 | 1040.8 | 1132.54 | 1209.39 | 50.44 | 20.88 | 18.67 |
| painting | 21.68 | 31.63 | 22.67 | 10.82 | 20.31 | 10.82 | 21.68 | 21.42 | 97.15 | 34.59 | 30.95 |
| rendering | 603.24 | 908.87 | 818.97 | 789.3 | 877.77 | 603.24 | 818.97 | 799.63 | 38.22 | 14.94 | 13.36 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 1252.22 | 1072.6 | 943.46 | 891.76 | 1345.97 | 891.76 | 1072.6 | 1101.2 | 41.25 | 17.72 | 15.85 |
| painting | 15.74 | 16.95 | 11.27 | 17.53 | 9.77 | 9.77 | 15.74 | 14.25 | 54.46 | 24.63 | 22.04 |
| rendering | 417.25 | 349.34 | 312.1 | 294.99 | 332.53 | 294.99 | 332.53 | 341.24 | 35.83 | 13.83 | 12.37 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 2571.43 | 1742.68 | 1523.94 | 1463.49 | 1618.59 | 1463.49 | 1618.59 | 1784.03 | 62.10 | 25.37 | 22.69 |
| painting | 27.89 | 22.77 | 25.3 | 14.21 | 18.04 | 14.21 | 22.77 | 21.64 | 63.22 | 25.51 | 22.83 |
| rendering | 754.66 | 539.9 | 473.77 | 465.9 | 492.79 | 465.9 | 492.79 | 545.4 | 52.94 | 22.09 | 19.75 |
| OPEN_MODAL | |||||||||||
| scripting | 727.83 | 525.4 | 473.53 | 485.93 | 523.95 | 473.53 | 523.95 | 547.33 | 46.46 | 18.90 | 16.91 |
| painting | 19.45 | 12.82 | 8.38 | 15.06 | 11.47 | 8.38 | 12.82 | 13.44 | 82.37 | 30.80 | 27.53 |
| rendering | 558.66 | 415.33 | 382.76 | 411.49 | 413.05 | 382.76 | 413.05 | 436.26 | 40.32 | 15.98 | 14.29 |
| CLOSE_MODAL | |||||||||||
| scripting | 318.81 | 256.65 | 253.47 | 350.32 | 232.68 | 232.68 | 256.65 | 282.39 | 41.66 | 17.63 | 15.77 |
| painting | 6.36 | 5.02 | 15.05 | 5.61 | 9.36 | 5.02 | 6.36 | 8.28 | 121.14 | 50.00 | 44.69 |
| rendering | 445.31 | 354.58 | 363.48 | 347.18 | 354.51 | 347.18 | 354.58 | 373.01 | 26.31 | 10.95 | 9.79 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 1076.76 | 974.89 | 311.6 | 1081.65 | 997.62 | 311.6 | 997.62 | 888.5 | 86.67 | 36.68 | 32.81 |
| painting | 9.25 | 6.63 | 13.51 | 7.97 | 18.31 | 6.63 | 9.25 | 11.13 | 104.94 | 42.86 | 38.36 |
| rendering | 681.53 | 638.11 | 636.59 | 708.51 | 637.03 | 636.59 | 638.11 | 660.35 | 10.89 | 5.01 | 4.48 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 187.92 | 183.25 | 169.25 | 221.69 | 148.48 | 148.48 | 183.25 | 182.12 | 40.20 | 14.78 | 13.22 |
| painting | 3.24 | 2.43 | 13.31 | 4.69 | 8.71 | 2.43 | 4.69 | 6.48 | 167.90 | 69.75 | 62.35 |
| rendering | 361.36 | 319.34 | 312.22 | 321.15 | 298.91 | 298.91 | 319.34 | 322.6 | 19.36 | 7.24 | 6.48 |
Deployment failed with the following error:
Resource is limited - try again in 22 minutes (more than 100, code: "api-deployments-free-per-day").
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3149356565.
Workflow: Appsmith External Integration Test Workflow.
Commit: b3ea5de.
PR: 16733.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3149356565.
Commit: ``.
Results: Click to view performance test results
| Run 1 (ms) | Run 2 (ms) | Run 3 (ms) | Run 4 (ms) | Run 5 (ms) | Minimum (ms) | Median (ms) | Mean (ms) | Range (%) | SD.Sample (%) | SD.Population (%) | |
|---|---|---|---|---|---|---|---|---|---|---|---|
| SELECT_CATEGORY | |||||||||||
| scripting | 431.9 | 378 | 388.7 | 453.82 | 359.51 | 359.51 | 388.7 | 402.39 | 23.44 | 9.73 | 8.71 |
| painting | 5.28 | 3.34 | 3.31 | 4.19 | 6.1 | 3.31 | 4.19 | 4.44 | 62.84 | 27.70 | 24.77 |
| rendering | 114.01 | 110.23 | 121.71 | 117.81 | 104.49 | 104.49 | 114.01 | 113.65 | 15.15 | 5.87 | 5.25 |
| BIND_TABLE_DATA | |||||||||||
| scripting | 2097.77 | 1110.99 | 1005.23 | 1399.19 | 1059.2 | 1005.23 | 1110.99 | 1334.48 | 81.87 | 33.95 | 30.36 |
| painting | 53.97 | 25.25 | 10.74 | 33.85 | 16.97 | 10.74 | 25.25 | 28.16 | 153.52 | 59.84 | 53.52 |
| rendering | 1076.46 | 864.41 | 774.14 | 988.35 | 813.7 | 774.14 | 864.41 | 903.41 | 33.46 | 13.94 | 12.47 |
| CLICK_ON_TABLE_ROW | |||||||||||
| scripting | 1549.24 | 992.51 | 951.25 | 1365.05 | 1049.79 | 951.25 | 1049.79 | 1181.57 | 50.61 | 22.19 | 19.85 |
| painting | 24.78 | 12.85 | 17.69 | 23.4 | 21.32 | 12.85 | 21.32 | 20.01 | 59.62 | 24.04 | 21.49 |
| rendering | 507.16 | 326.45 | 306.62 | 376.52 | 310.86 | 306.62 | 326.45 | 365.52 | 54.86 | 22.96 | 20.54 |
| UPDATE_POST_TITLE | |||||||||||
| scripting | 2090.86 | 1433.66 | 1463.88 | 2166.08 | 1670.99 | 1433.66 | 1670.99 | 1765.09 | 41.49 | 19.55 | 17.49 |
| painting | 18.9 | 15.35 | 16.95 | 22.64 | 19.29 | 15.35 | 18.9 | 18.63 | 39.13 | 14.76 | 13.20 |
| rendering | 757.28 | 671.87 | 607.32 | 733.5 | 669.81 | 607.32 | 671.87 | 687.96 | 21.80 | 8.59 | 7.68 |
| OPEN_MODAL | |||||||||||
| scripting | 507.33 | 469.65 | 493.18 | 657.72 | 468.91 | 468.91 | 493.18 | 519.36 | 36.35 | 15.22 | 13.61 |
| painting | 9.31 | 14.12 | 13.13 | 26.67 | 9.29 | 9.29 | 13.13 | 14.5 | 119.86 | 49.31 | 44.07 |
| rendering | 1310.55 | 1232.81 | 1222.63 | 1361.14 | 1259.21 | 1222.63 | 1259.21 | 1277.27 | 10.84 | 4.54 | 4.06 |
| CLOSE_MODAL | |||||||||||
| scripting | 327.48 | 236.42 | 208.98 | 836.35 | 214.74 | 208.98 | 236.42 | 364.79 | 171.98 | 73.43 | 65.68 |
| painting | 5.93 | 10.23 | 5.29 | 6.14 | 13.54 | 5.29 | 6.14 | 8.23 | 100.24 | 43.13 | 38.64 |
| rendering | 1145.02 | 939.07 | 956.92 | 964.26 | 942.1 | 939.07 | 956.92 | 989.47 | 20.81 | 8.85 | 7.92 |
| SELECT_WIDGET_MENU_OPEN | |||||||||||
| scripting | 1020.49 | 927.82 | 1182.12 | 1011.02 | 982.64 | 927.82 | 1011.02 | 1024.82 | 24.81 | 9.27 | 8.30 |
| painting | 7.01 | 5.55 | 9.59 | 13.54 | 13.22 | 5.55 | 9.59 | 9.78 | 81.70 | 36.71 | 32.82 |
| rendering | 729.49 | 646.5 | 771.82 | 708.05 | 682.83 | 646.5 | 708.05 | 707.74 | 17.71 | 6.68 | 5.98 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||||
| scripting | 159.15 | 162.83 | 198.34 | 159.62 | 188.6 | 159.15 | 162.83 | 173.71 | 22.56 | 10.60 | 9.49 |
| painting | 2.27 | 2.02 | 3.33 | 6.47 | 5.69 | 2.02 | 3.33 | 3.96 | 112.37 | 51.01 | 45.71 |
| rendering | 340.04 | 304.56 | 391.61 | 316.57 | 337.31 | 304.56 | 337.31 | 338.02 | 25.75 | 9.88 | 8.83 |