appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

feat: decouple redux and the view layer in CalloutV2

Open tanvibhakta opened this issue 3 years ago • 12 comments

Description

Refactor Group component so it can pass the appropriate prop to CalloutV2. Fixes https://github.com/appsmithorg/appsmith/issues/16624

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally on ee, as well as on the DP

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

tanvibhakta avatar Sep 07 '22 23:09 tanvibhakta

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 28, 2022 at 1:38AM (UTC)

vercel[bot] avatar Sep 07 '22 23:09 vercel[bot]

/ok-to-test sha=4877e51

tanvibhakta avatar Sep 07 '22 23:09 tanvibhakta

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Sep 07 '22 23:09 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3011289719. Workflow: Appsmith External Integration Test Workflow. Commit: 4877e51. PR: 16625.

github-actions[bot] avatar Sep 07 '22 23:09 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 19 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Sep 07 '22 23:09 vercel[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Sep 15 '22 16:09 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Sep 19 '22 06:09 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Sep 19 '22 06:09 github-actions[bot]

/ok-to-test sha=32ba9c6

tanvibhakta avatar Sep 19 '22 07:09 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3081014497. Workflow: Appsmith External Integration Test Workflow. Commit: 32ba9c6. PR: 16625.

github-actions[bot] avatar Sep 19 '22 08:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3081014497. Commit: ``. Results:

Click to view performance test results

| | Run 1 (ms)| Run 2 (ms)| Run 3 (ms)| Run 4 (ms)| Run 5 (ms)| Minimum (ms)| Median (ms)| Mean (ms)| Range (%) | SD.Sample (%) | SD.Population (%)| | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | SELECT_CATEGORY| | | | | | | | | | | | scripting | 369.97 | 363.39 | 337.35 | 375.32 | 373.13 | 337.35| 369.97| 363.83 | 10.44| 4.25 | 3.80| | painting | 4.84 | 5.5 | 7.01 | 5.57 | 3.25 | 3.25| 5.5| 5.23 | 71.89| 26.00 | 23.33| | rendering | 106.87 | 107.13 | 105.24 | 107.12 | 106.22 | 105.24| 106.87| 106.52 | 1.77| 0.75 | 0.68| BIND_TABLE_DATA| | | | | | | | | | | | scripting | 1168.74 | 1056.75 | 994.18 | 1102.56 | 1088.32 | 994.18| 1088.32| 1082.11 | 16.13| 5.91 | 5.28| | painting | 32.05 | 20.92 | 21.28 | 27.31 | 21.9 | 20.92| 21.9| 24.69 | 45.08| 19.68 | 17.62| | rendering | 910.82 | 853.89 | 836.47 | 845.84 | 831.72 | 831.72| 845.84| 855.75 | 9.24| 3.73 | 3.34| CLICK_ON_TABLE_ROW| | | | | | | | | | | | scripting | 1240.08 | 933.59 | 978.51 | 858.19 | 1171.73 | 858.19| 978.51| 1036.42 | 36.85| 15.67 | 14.01| | painting | 15.1 | 10.2 | 9.7 | 14.39 | 14.39 | 9.7| 14.39| 12.76 | 42.32| 20.22 | 18.10| | rendering | 368.05 | 313.08 | 311.16 | 300.65 | 305.81 | 300.65| 311.16| 319.75 | 21.08| 8.58 | 7.67| UPDATE_POST_TITLE| | | | | | | | | | | | scripting | 2449.29 | 1428.73 | 1576.73 | 1500.33 | 1557.17 | 1428.73| 1557.17| 1702.45 | 59.95| 24.75 | 22.14| | painting | 26.26 | 17.03 | 16.78 | 14.69 | 16.39 | 14.69| 16.78| 18.23 | 63.47| 25.12 | 22.49| | rendering | 782.2 | 608.04 | 646.46 | 614.33 | 658.92 | 608.04| 646.46| 661.99 | 26.31| 10.65 | 9.53| OPEN_MODAL| | | | | | | | | | | | scripting | 479.65 | 426.88 | 492.62 | 484.31 | 615.58 | 426.88| 484.31| 499.81 | 37.75| 13.94 | 12.47| | painting | 8.35 | 10.32 | 21 | 8.93 | 16.64 | 8.35| 10.32| 13.05 | 96.93| 42.45 | 37.93| | rendering | 1285.04 | 1197.44 | 1255.1 | 1218.24 | 1560.08 | 1197.44| 1255.1| 1303.18 | 27.83| 11.32 | 10.12| CLOSE_MODAL| | | | | | | | | | | | scripting | 204.94 | 200.05 | 193.4 | 209.63 | 258.73 | 193.4| 204.94| 213.35 | 30.62| 12.22 | 10.93| | painting | 5.31 | 7.02 | 17.94 | 5.29 | 9.52 | 5.29| 7.02| 9.02 | 140.24| 58.54 | 52.33| | rendering | 953.16 | 925.9 | 934.03 | 927.71 | 1121.32 | 925.9| 934.03| 972.42 | 20.10| 8.63 | 7.72| SELECT_WIDGET_MENU_OPEN| | | | | | | | | | | | scripting | 988.35 | 976.35 | 1095.27 | 955.11 | 1751.74 | 955.11| 988.35| 1153.36 | 69.07| 29.38 | 26.28| | painting | 9.85 | 9.41 | 8.72 | 5.48 | 9.19 | 5.48| 9.19| 8.53 | 51.23| 20.52 | 18.41| | rendering | 680.7 | 663.4 | 756.39 | 661.76 | 1367.82 | 661.76| 680.7| 826.01 | 85.48| 36.97 | 33.06| SELECT_WIDGET_SELECT_OPTION| | | | | | | | | | | | scripting | 163.79 | 159.71 | 182.09 | 160.34 | 348.36 | 159.71| 163.79| 202.86 | 93.00| 40.35 | 36.09| | painting | 2.59 | 5.72 | 3.16 | 2.48 | 7.88 | 2.48| 3.16| 4.37 | 123.57| 54.00 | 48.28| | rendering | 311.06 | 316.5 | 354.79 | 303.39 | 722.94 | 303.39| 316.5| 401.74 | 104.43| 44.97 | 40.22|

github-actions[bot] avatar Sep 19 '22 09:09 github-actions[bot]

Errors while compiling this PR. Reopening this issue

shadabbuchh avatar Sep 21 '22 10:09 shadabbuchh

This PR has been tested. No issues found.

shadabbuchh avatar Sep 27 '22 11:09 shadabbuchh

/ok-to-test sha=73c8f14

tanvibhakta avatar Sep 27 '22 11:09 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3135334492. Workflow: Appsmith External Integration Test Workflow. Commit: 73c8f14. PR: 16625.

github-actions[bot] avatar Sep 27 '22 11:09 github-actions[bot]

/ok-to-test sha=7dd249f

tanvibhakta avatar Sep 27 '22 14:09 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3136375781. Workflow: Appsmith External Integration Test Workflow. Commit: 7dd249f. PR: 16625.

github-actions[bot] avatar Sep 27 '22 14:09 github-actions[bot]

/ok-to-test sha=4e49e42

tanvibhakta avatar Sep 28 '22 01:09 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3140181122. Workflow: Appsmith External Integration Test Workflow. Commit: 4e49e42. PR: 16625.

github-actions[bot] avatar Sep 28 '22 01:09 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/3140181122. Commit: ``. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Minimum (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 335.91 367.39 326.88 343.65 359.32 326.88 343.65 346.63 11.69 4.80 4.29
painting 7.5 10.52 3.19 6.27 5.39 3.19 6.27 6.57 111.57 41.25 36.83
rendering 104.68 104.95 101.47 105.88 112.45 101.47 104.95 105.89 10.37 3.81 3.40
BIND_TABLE_DATA
scripting 1050.98 1128.67 1136.99 1137.93 1077.3 1050.98 1128.67 1106.37 7.86 3.60 3.22
painting 18.7 22.26 21.68 22.15 20.75 18.7 21.68 21.11 16.86 6.96 6.25
rendering 803.96 818.49 829.84 800.53 796.54 796.54 803.96 809.87 4.11 1.72 1.53
CLICK_ON_TABLE_ROW
scripting 787.67 937.88 900.01 935.03 951.92 787.67 935.03 902.5 18.20 7.42 6.64
painting 9.88 11.03 9.36 8.86 9.69 8.86 9.69 9.76 22.23 8.30 7.38
rendering 289.28 293.11 314.37 323.46 304.94 289.28 304.94 305.03 11.21 4.68 4.19
UPDATE_POST_TITLE
scripting 1494.61 1395.28 1337.42 1475.77 1394.14 1337.42 1395.28 1419.44 11.07 4.56 4.08
painting 18.7 16.46 13.28 15.18 12.74 12.74 15.18 15.27 39.03 15.91 14.21
rendering 588.56 606.86 590.15 600.01 600.11 588.56 600.01 597.14 3.06 1.28 1.15
OPEN_MODAL
scripting 480.94 416.81 460.76 452.28 461.55 416.81 460.76 454.47 14.11 5.18 4.63
painting 9.34 11.85 7.28 16.06 15.3 7.28 11.85 11.97 73.35 31.50 28.15
rendering 1168.37 1140.75 1190.8 1177.09 1166.9 1140.75 1168.37 1168.78 4.28 1.57 1.40
CLOSE_MODAL
scripting 227.92 196.09 189.42 191.6 193.77 189.42 193.77 199.76 19.27 7.98 7.13
painting 12.98 11.38 9.71 10.8 10.14 9.71 10.8 11 29.73 11.64 10.36
rendering 866.92 848.98 885.19 876.78 883.08 848.98 876.78 872.19 4.15 1.70 1.52
SELECT_WIDGET_MENU_OPEN
scripting 948.6 919.62 926.27 927.97 965.49 919.62 927.97 937.59 4.89 2.03 1.81
painting 13.78 11.98 12.79 5.63 6.89 5.63 11.98 10.21 79.82 36.14 32.32
rendering 641.41 631.5 634.89 646.1 656.17 631.5 641.41 642.01 3.84 1.52 1.36
SELECT_WIDGET_SELECT_OPTION
scripting 149.54 152.66 155.99 161.82 166.82 149.54 155.99 157.37 10.98 4.43 3.97
painting 3.1 6.62 4.51 3.55 3.29 3.1 3.55 4.21 83.61 34.44 30.88
rendering 303.45 305.34 310.77 306.09 314.08 303.45 306.09 307.95 3.45 1.42 1.27

github-actions[bot] avatar Sep 28 '22 02:09 github-actions[bot]