appsmithorg
fix: Make default DB compulsory in URI string format
Description
In the form mode of configuring a Mongo datasource, we have made the default DB a compulsory field so we know which DB to run queries against. This PR adds the same validation for the URI string format.
On running queries:
On testing datasource:
Fixes #12713
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- JUnit Test
- Manual test
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Aug 11, 2022 at 7:39AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2830395079.
Workflow: Appsmith External Integration Test Workflow.
Commit: fc04018.
PR: 15881.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2830395079.
Commit: fc04018.
Results: Click to view performance test results
| Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
|---|---|---|---|---|---|---|---|---|---|
| SELECT_WIDGET_MENU_OPEN | |||||||||
| scripting | 1085.37 | 1088.95 | 1086.63 | 1093.42 | 1049.4 | 1086.63 | 1080.75 | 1.65 | 1.47 |
| painting | 5.65 | 11.12 | 12.12 | 9.52 | 6.38 | 9.52 | 8.96 | 31.81 | 28.46 |
| rendering | 848.13 | 819.54 | 861.28 | 859.95 | 824.18 | 848.13 | 842.62 | 2.34 | 2.09 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||
| scripting | 146.2 | 152.28 | 166.19 | 146.4 | 172.89 | 152.28 | 156.79 | 7.73 | 6.91 |
| painting | 10.36 | 3.5 | 6.75 | 10.22 | 2.51 | 6.75 | 6.67 | 54.87 | 49.03 |
| rendering | 317.11 | 307.14 | 309.73 | 307.65 | 296.38 | 307.65 | 307.6 | 2.42 | 2.16 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2831342398.
Workflow: Appsmith External Integration Test Workflow.
Commit: bbef825.
PR: 15881.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2834260091.
Workflow: Appsmith External Integration Test Workflow.
Commit: 956f17b.
PR: 15881.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2834260091.
Workflow: Appsmith External Integration Test Workflow.
Commit: 956f17b.
PR: 15881.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2834260091.
Commit: 956f17b.
Results: Click to view performance test results
| Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
|---|---|---|---|---|---|---|---|---|---|
| SELECT_WIDGET_MENU_OPEN | |||||||||
| scripting | 1041.95 | 1069.84 | 1069.94 | 1049.82 | 1045.16 | 1049.82 | 1055.34 | 1.29 | 1.15 |
| painting | 7.95 | 10.77 | 6.47 | 10.57 | 5.48 | 7.95 | 8.25 | 28.85 | 25.82 |
| rendering | 818.03 | 828.27 | 821.37 | 811.75 | 815.67 | 818.03 | 819.02 | 0.76 | 0.68 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||
| scripting | 161.03 | 145.38 | 149.74 | 167.82 | 145.59 | 149.74 | 153.91 | 6.52 | 5.83 |
| painting | 2.21 | 3.04 | 6.1 | 7.74 | 11.27 | 6.1 | 6.07 | 60.46 | 54.04 |
| rendering | 294.46 | 307.66 | 308.4 | 303.61 | 300.86 | 303.61 | 303 | 1.87 | 1.67 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2838711101.
Workflow: Appsmith External Integration Test Workflow.
Commit: 79738d1.
PR: 15881.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2838711101.
Commit: 79738d1.
Results: Click to view performance test results
| Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
|---|---|---|---|---|---|---|---|---|---|
| SELECT_WIDGET_MENU_OPEN | |||||||||
| scripting | 1099.12 | 1119.14 | 1176.83 | 1081.17 | 1074.36 | 1099.12 | 1110.12 | 3.71 | 3.31 |
| painting | 8.46 | 5.59 | 6.32 | 6.13 | 6.31 | 6.31 | 6.56 | 16.77 | 15.09 |
| rendering | 865.36 | 855.3 | 908.52 | 840.3 | 829.9 | 855.3 | 859.88 | 3.54 | 3.16 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||
| scripting | 162.76 | 171.22 | 157.81 | 161.96 | 160.78 | 161.96 | 162.91 | 3.08 | 2.75 |
| painting | 2.17 | 8.67 | 4.94 | 2.46 | 4.96 | 4.94 | 4.64 | 56.25 | 50.43 |
| rendering | 308.72 | 321.49 | 313.89 | 303.54 | 314.19 | 313.89 | 312.37 | 2.15 | 1.92 |