appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

feat: import changes batch 2

Open tanvibhakta opened this issue 3 years ago • 10 comments

Import changes for

  • Toggle - fixes https://github.com/appsmithorg/appsmith/issues/15721
  • Menu - fixes https://github.com/appsmithorg/appsmith/issues/15723
  • Spinner - fixes https://github.com/appsmithorg/appsmith/issues/15724
  • Radio - fixes https://github.com/appsmithorg/appsmith/issues/15730
  • tree dropdown - fixes https://github.com/appsmithorg/appsmith/issues/15726
  • Notification Banner - fixes https://github.com/appsmithorg/appsmith/issues/15731
  • ListSegmentHeader - fixes https://github.com/appsmithorg/appsmith/issues/15743
  • TagInputComponent - fixes https://github.com/appsmithorg/appsmith/issues/15819
  • Switch - fixes https://github.com/appsmithorg/appsmith/issues/15820
  • SearchInput - https://github.com/appsmithorg/appsmith/issues/15821
  • ProgressiveImage - https://github.com/appsmithorg/appsmith/issues/15823
  • MenuDivider - https://github.com/appsmithorg/appsmith/issues/15824
  • 5 components used only in one place: https://github.com/appsmithorg/appsmith/issues/15826
  • 9 more components used only in one place or not used: https://github.com/appsmithorg/appsmith/issues/15844

Testing on local by running yarn build on both ce and ee.

tanvibhakta avatar Aug 04 '22 13:08 tanvibhakta

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 5:20AM (UTC)

vercel[bot] avatar Aug 04 '22 13:08 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 04 '22 13:08 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 05 '22 07:08 github-actions[bot]

/ok-to-test sha=9a2d5da

tanvibhakta avatar Aug 08 '22 13:08 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2818179043. Workflow: Appsmith External Integration Test Workflow. Commit: 9a2d5da. PR: 15722.

github-actions[bot] avatar Aug 08 '22 13:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2818179043. Commit: 9a2d5da. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1310.21 1346.12 1201.96 1137.78 1219.1 1219.1 1243.03 6.79 6.07
painting 13.89 13.64 9.37 10.06 20.09 13.64 13.41 31.77 28.41
rendering 999.34 995.75 908.41 914.01 932.71 932.71 950.04 4.66 4.17
SELECT_WIDGET_SELECT_OPTION
scripting 216.33 253.02 169.22 165.52 297.12 216.33 220.24 25.48 22.79
painting 7.11 6.94 4.25 3.71 4.13 4.25 5.23 31.55 28.30
rendering 353.93 496.67 313.63 313.46 415.53 353.93 378.64 20.62 18.44

github-actions[bot] avatar Aug 08 '22 14:08 github-actions[bot]

/ok-to-test sha=9f792c0

tanvibhakta avatar Aug 09 '22 13:08 tanvibhakta

/ok-to-test sha=9f792c0

tanvibhakta avatar Aug 09 '22 13:08 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2826555479. Workflow: Appsmith External Integration Test Workflow. Commit: 9f792c0. PR: 15722.

github-actions[bot] avatar Aug 09 '22 16:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2826555479. Commit: 9f792c0. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1161.36 1054.98 998.92 1047.47 1046.09 1047.47 1061.76 5.64 5.05
painting 8 5.04 5.31 7.71 5.72 5.72 6.36 21.86 19.65
rendering 882.81 809.91 808.88 852.64 824.68 824.68 835.78 3.79 3.39
SELECT_WIDGET_SELECT_OPTION
scripting 156.96 157.8 146.39 197.88 150 156.96 161.81 12.81 11.46
painting 11.24 3.43 10.81 2.9 2.73 3.43 6.22 70.58 63.18
rendering 294.27 298.24 304.12 301.17 309.87 301.17 301.53 1.96 1.75

github-actions[bot] avatar Aug 09 '22 16:08 github-actions[bot]

/ok-to-test sha=9a2d5da

tanvibhakta avatar Aug 10 '22 13:08 tanvibhakta

/ok-to-test sha=520bf82

tanvibhakta avatar Aug 11 '22 02:08 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2837010671. Workflow: Appsmith External Integration Test Workflow. Commit: 520bf82. PR: 15722.

github-actions[bot] avatar Aug 11 '22 02:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2837010671. Commit: 520bf82. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1088.23 1090.41 1074.6 1104.15 1085.51 1088.23 1088.58 0.98 0.87
painting 10.66 8.36 11.68 11.41 5.48 10.66 9.52 27.42 24.47
rendering 879.23 840.59 839.9 830.31 858.63 840.59 849.73 2.28 2.04
SELECT_WIDGET_SELECT_OPTION
scripting 154.02 155.32 160.57 162.89 169.51 160.57 160.46 3.89 3.48
painting 2.43 8.78 2.83 2.55 4.36 2.83 4.19 63.96 57.28
rendering 316.52 310.31 306.15 314.24 340.87 314.24 317.62 4.28 3.83

github-actions[bot] avatar Aug 11 '22 03:08 github-actions[bot]

/ok-to-test sha=a25a8da

tanvibhakta avatar Aug 13 '22 09:08 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2851528651. Workflow: Appsmith External Integration Test Workflow. Commit: a25a8da. PR: 15722.

github-actions[bot] avatar Aug 13 '22 09:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2851528651. Commit: a25a8da. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1075.54 1109.15 1033.11 1005.41 1125.24 1075.54 1069.69 4.71 4.21
painting 8.38 15.61 5.57 9.6 5.59 8.38 8.95 46.03 41.12
rendering 827.96 862.77 803.64 798.93 875.35 827.96 833.73 4.12 3.69
SELECT_WIDGET_SELECT_OPTION
scripting 162.56 146.71 168.17 156.58 159.2 159.2 158.64 5.01 4.48
painting 1.95 4.99 4.84 5.54 2.64 4.84 3.99 39.85 35.59
rendering 303.47 310.6 303.56 300.14 299.88 303.47 303.53 1.42 1.27

github-actions[bot] avatar Aug 13 '22 10:08 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Aug 20 '22 16:08 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 2 hours (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Aug 23 '22 03:08 vercel[bot]

/ok-to-test sha=015b992

tanvibhakta avatar Aug 23 '22 03:08 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2908639086. Workflow: Appsmith External Integration Test Workflow. Commit: 015b992. PR: 15722.

github-actions[bot] avatar Aug 23 '22 03:08 github-actions[bot]

Deployment failed with the following error:

Resource is limited - try again in 1 hour (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Aug 23 '22 03:08 vercel[bot]

/ok-to-test sha=a9a4fb7

tanvibhakta avatar Aug 23 '22 03:08 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2908740325. Workflow: Appsmith External Integration Test Workflow. Commit: a9a4fb7. PR: 15722.

github-actions[bot] avatar Aug 23 '22 03:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2908740325. Commit: a9a4fb7. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 290.51 303.17 314.53 295.02 293.46 295.02 299.34 8.02 3.24 2.90
painting 4.34 3.61 5.35 3.55 5.37 4.34 4.44 40.99 20.05 18.02
rendering 107.79 111.7 108.32 109.97 108.77 108.77 109.31 3.58 1.43 1.27
BIND_TABLE_DATA
scripting 1199.22 1216.37 1182.74 1162.14 1228.66 1199.22 1197.83 5.55 2.21 1.97
painting 14.78 17.81 14.1 16.42 19.14 16.42 16.45 30.64 12.71 11.37
rendering 797.11 773.28 809.98 762.82 795.73 795.73 787.78 5.99 2.44 2.18
CLICK_ON_TABLE_ROW
scripting 779.85 1113.49 1141.38 1129.13 850.16 1113.49 1002.8 36.05 17.30 15.48
painting 11.77 10.59 12.64 17.25 15.08 12.64 13.47 49.44 19.90 17.82
rendering 312.13 298.72 306.56 304.68 313.52 306.56 307.12 4.82 1.95 1.74
UPDATE_POST_TITLE
scripting 1346.6 1342.56 1346.4 1279.78 1300.63 1342.56 1323.19 5.05 2.35 2.10
painting 16.59 14.24 16.74 16.42 12.87 16.42 15.37 25.18 11.26 10.08
rendering 443 442.56 444.1 439.13 450.83 443 443.92 2.64 0.96 0.86
OPEN_MODAL
scripting 506.3 513.46 522.17 530.18 503.47 513.46 515.12 5.19 2.15 1.93
painting 11.98 12.11 7.97 8.81 8.98 8.98 9.97 41.52 19.36 17.35
rendering 386.54 380.21 395.57 372.89 361.99 380.21 379.44 8.85 3.38 3.03
CLOSE_MODAL
scripting 328.45 306.92 299.41 324.61 783.16 324.61 408.51 118.42 51.35 45.93
painting 11.99 7.3 5.93 4.71 27.26 7.3 11.44 197.12 81.03 72.47
rendering 664.67 608.8 604.57 664.79 623.73 623.73 633.31 9.51 4.67 4.17
SELECT_WIDGET_MENU_OPEN
scripting 1047.51 1064.68 1052.93 1038.61 1080.27 1052.93 1056.8 3.94 1.53 1.37
painting 10.8 14.26 8.55 7.85 7.63 8.55 9.82 67.52 28.31 25.36
rendering 616.7 604.56 621.47 607.89 643.4 616.7 618.8 6.28 2.48 2.21
SELECT_WIDGET_SELECT_OPTION
scripting 138.88 142.32 146.44 143.13 165.4 143.13 147.23 18.01 7.13 6.38
painting 3.53 5.62 3.8 2.19 12.43 3.8 5.51 185.84 73.50 65.88
rendering 306.62 315.94 318.82 316.86 319.2 316.86 315.49 3.99 1.63 1.46

github-actions[bot] avatar Aug 23 '22 04:08 github-actions[bot]

/ok-to-test sha=a29cd9a

albinAppsmith avatar Aug 24 '22 04:08 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2916401775. Workflow: Appsmith External Integration Test Workflow. Commit: a29cd9a. PR: 15722.

github-actions[bot] avatar Aug 24 '22 04:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2916401775. Commit: a29cd9a. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 331.05 367.94 305.99 300.11 283 305.99 317.62 26.74 10.39 9.29
painting 3.17 3.74 4.02 4.62 3.58 3.74 3.83 37.86 14.10 12.53
rendering 108.08 150.37 105.84 106.32 104.82 106.32 115.09 39.58 17.17 15.35
BIND_TABLE_DATA
scripting 1455.55 1532.39 1493.92 1472.35 1553.24 1493.92 1501.49 6.51 2.72 2.43
painting 14.07 26.63 14.52 14.33 19.31 14.52 17.77 70.68 30.44 27.24
rendering 416.59 555.7 414.6 422.7 455.46 422.7 453.01 31.15 13.19 11.79
CLICK_ON_TABLE_ROW
scripting 760.56 1297.87 844.84 843.77 854.4 844.84 920.29 58.38 23.30 20.84
painting 8.84 11.38 9.58 8.61 16.96 9.58 11.07 75.43 31.35 28.00
rendering 295.42 319.26 294.04 297.1 296.21 296.21 300.41 8.40 3.53 3.16
UPDATE_POST_TITLE
scripting 1362.74 1497.76 1282.97 1320.24 1859.49 1362.74 1464.64 39.36 16.06 14.36
painting 20.49 14.83 16.98 16.07 23.33 16.98 18.34 46.35 19.03 17.07
rendering 428.09 485.81 443.03 486.11 440.93 443.03 456.79 12.70 5.96 5.33
OPEN_MODAL
scripting 517.45 528.93 475.93 499.93 490.9 499.93 502.63 10.54 4.18 3.74
painting 14.77 9.51 11.89 7.15 13.49 11.89 11.36 67.08 27.02 24.12
rendering 376.15 393.7 366.77 367.45 363.42 367.45 373.5 8.11 3.27 2.93
CLOSE_MODAL
scripting 320.45 330.48 311.33 308.49 274.26 311.33 309 18.19 6.87 6.15
painting 4.97 10.23 4.66 4.42 4.42 4.66 5.74 101.22 43.90 39.20
rendering 630.56 664.12 604.42 605.55 594.58 605.55 619.85 11.22 4.53 4.05
SELECT_WIDGET_MENU_OPEN
scripting 1119.96 1056.8 1050.05 1105.53 1121.07 1105.53 1090.68 6.51 3.18 2.84
painting 8.99 11.2 5.13 9.41 14.96 9.41 9.94 98.89 35.92 32.19
rendering 633.97 593.58 591.55 617.97 675.49 617.97 622.51 13.48 5.54 4.95
SELECT_WIDGET_SELECT_OPTION
scripting 155.3 150.35 135.41 140.77 181.5 150.35 152.67 30.19 11.73 10.49
painting 2.35 3.26 2.13 5.29 5.93 3.26 3.79 100.26 45.65 40.90
rendering 325.35 307.62 300.22 310.87 311.06 310.87 311.02 8.08 2.94 2.63

github-actions[bot] avatar Aug 24 '22 05:08 github-actions[bot]

/ok-to-test sha=6ab52bc

albinAppsmith avatar Aug 25 '22 04:08 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2924048469. Workflow: Appsmith External Integration Test Workflow. Commit: 6ab52bc. PR: 15722.

github-actions[bot] avatar Aug 25 '22 04:08 github-actions[bot]