appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix: navigation issue in the Iframe widget due to src change

Open techbhavin opened this issue 3 years ago • 19 comments

Description

Fixed the navigation issue in the Iframe widget due to the src change.

Fixes #15585

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

techbhavin avatar Aug 03 '22 09:08 techbhavin

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Aug 15, 2022 at 11:09AM (UTC)

vercel[bot] avatar Aug 03 '22 09:08 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 03 '22 09:08 github-actions[bot]

/ok-to-test sha=d9db302

techbhavin avatar Aug 03 '22 09:08 techbhavin

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2788378028. Workflow: Appsmith External Integration Test Workflow. Commit: d9db302. PR: 15656.

github-actions[bot] avatar Aug 03 '22 09:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2788378028. Commit: d9db302. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1075.22 1127.22 1086.86 1085.05 1068.5 1085.05 1088.57 2.10 1.88
painting 15.04 5.67 8.26 9.24 12.72 9.24 10.19 36.41 32.58
rendering 782.98 761.21 772.61 751.31 768.51 768.51 767.32 1.55 1.39
SELECT_WIDGET_SELECT_OPTION
scripting 191.75 161.55 161.33 160.97 177.68 161.55 170.66 8.07 7.21
painting 3.42 2.58 2.55 6.41 2.06 2.58 3.4 51.47 46.18
rendering 272.23 249.19 247.96 250.89 248.96 249.19 253.85 4.07 3.64

github-actions[bot] avatar Aug 03 '22 14:08 github-actions[bot]

/ok-to-test sha=6eb1974

techbhavin avatar Aug 05 '22 09:08 techbhavin

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2802787971. Workflow: Appsmith External Integration Test Workflow. Commit: 6eb1974. PR: 15656.

github-actions[bot] avatar Aug 05 '22 09:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2802787971. Commit: 6eb1974. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1117.98 1084.77 1047.82 1051.19 1026.95 1051.19 1065.74 3.36 3.01
painting 8.02 5.49 5.64 16.1 7.2 7.2 8.49 51.71 46.17
rendering 872.22 805.48 850.4 868.96 826.55 850.4 844.72 3.37 3.02
SELECT_WIDGET_SELECT_OPTION
scripting 178.73 157.87 145.61 191.77 159.24 159.24 166.64 11.03 9.87
painting 2.54 7.37 3.41 2.23 4.29 3.41 3.97 51.89 46.60
rendering 313.34 296.1 299.6 313.74 304.26 304.26 305.41 2.61 2.33

github-actions[bot] avatar Aug 05 '22 10:08 github-actions[bot]

Tested and verified.

laveena-en avatar Aug 05 '22 13:08 laveena-en

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 08 '22 05:08 github-actions[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 08 '22 05:08 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2802787971. Workflow: Appsmith External Integration Test Workflow. Commit: 6eb1974. PR: 15656.

github-actions[bot] avatar Aug 09 '22 05:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2802787971. Commit: 6eb1974. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1017.7 1083.99 1036.04 1107.37 1063.49 1063.49 1061.72 3.39 3.03
painting 5.79 7.25 6.27 15.95 8.68 7.25 8.79 47.21 42.21
rendering 805.39 824.92 805.06 869.49 819.21 819.21 824.81 3.20 2.87
SELECT_WIDGET_SELECT_OPTION
scripting 155.55 225.91 144.24 190.21 149.5 155.55 173.08 19.97 17.86
painting 4.99 8.98 5.96 3.69 7.69 5.96 6.26 33.71 30.03
rendering 291.73 293.5 306.4 311.95 302.87 302.87 301.29 2.85 2.55

github-actions[bot] avatar Aug 09 '22 06:08 github-actions[bot]

/ok-to-test sha=6eb1974

techbhavin avatar Aug 09 '22 07:08 techbhavin

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2823658595. Workflow: Appsmith External Integration Test Workflow. Commit: 6eb1974. PR: 15656.

github-actions[bot] avatar Aug 09 '22 07:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2823658595. Commit: 6eb1974. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1023.65 1019.16 1044.73 1029.26 1029.06 1029.06 1029.17 0.94 0.84
painting 9.08 11 5.74 6.98 10.3 9.08 8.62 25.75 22.97
rendering 812.68 800.97 819.58 808.9 823.19 812.68 813.06 1.08 0.97
SELECT_WIDGET_SELECT_OPTION
scripting 154.25 167.51 160.41 149.6 151.76 154.25 156.71 4.64 4.15
painting 5.46 3.34 5.09 3.58 9.28 5.09 5.35 44.49 39.81
rendering 299.41 294.77 295.7 294.33 304.61 295.7 297.76 1.45 1.30

github-actions[bot] avatar Aug 09 '22 08:08 github-actions[bot]

/ok-to-test sha=6eb1974

techbhavin avatar Aug 09 '22 08:08 techbhavin

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2823983845. Workflow: Appsmith External Integration Test Workflow. Commit: 6eb1974. PR: 15656.

github-actions[bot] avatar Aug 09 '22 08:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2823983845. Commit: 6eb1974. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1115.28 1092.08 1096.48 1107.58 1069.18 1096.48 1096.12 1.61 1.44
painting 6.81 6.99 5.73 5.89 7.7 6.81 6.62 12.39 11.03
rendering 837.41 825.03 847.79 855.55 845.67 845.67 842.29 1.38 1.23
SELECT_WIDGET_SELECT_OPTION
scripting 164.24 147.17 162.47 164.86 165.14 164.24 160.78 4.78 4.27
painting 6.68 3.84 5.67 3.47 5.5 5.5 5.03 26.64 23.86
rendering 301.7 300.92 317.75 312.08 313.04 312.08 309.1 2.40 2.15

github-actions[bot] avatar Aug 09 '22 13:08 github-actions[bot]

/ok-to-test sha=4d30499

techbhavin avatar Aug 15 '22 10:08 techbhavin

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2860165929. Workflow: Appsmith External Integration Test Workflow. Commit: 4d30499. PR: 15656.

github-actions[bot] avatar Aug 15 '22 11:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2860165929. Commit: 4d30499. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1030.08 1040.15 1022.46 1043.22 1101.14 1040.15 1047.41 2.97 2.66
painting 6.68 13.51 5.31 14.11 5.37 6.68 9 49.22 44.11
rendering 827.08 825.34 799.67 811.13 832.51 825.34 819.15 1.64 1.47
SELECT_WIDGET_SELECT_OPTION
scripting 141.9 156.13 142.69 150.02 148.97 148.97 147.94 3.95 3.54
painting 2.34 2.3 2.16 6.55 8.94 2.34 4.46 69.96 62.56
rendering 304.5 299.24 300.54 296.86 302.23 300.54 300.67 0.96 0.86

github-actions[bot] avatar Aug 15 '22 11:08 github-actions[bot]