appsmithorg
fix: Text getting clipped for Italic font in Table Widget V1
Description
For Italic and L sized font text is getting clipped towards the end in Table Widget V1. This issue does not exist in Table Widget V2 After trying out a few solutions concluded that adding padding to the right fixes this issue without breaking any other existing code. Thus went ahead with this approach.
Fixes #14489
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manually tested
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Aug 12, 2022 at 9:50AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unable to find test scripts. Please add necessary tests to the PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2801995638.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8fbc9e9.
PR: 15549.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2801995638.
Commit: 8fbc9e9.
Results: Click to view performance test results
| Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
|---|---|---|---|---|---|---|---|---|---|
| SELECT_WIDGET_MENU_OPEN | |||||||||
| scripting | 1068.45 | 1127.11 | 1091.08 | 1115.75 | 1113.31 | 1113.31 | 1103.14 | 2.12 | 1.90 |
| painting | 6.95 | 12.02 | 5.82 | 14.09 | 9.4 | 9.4 | 9.66 | 35.61 | 31.88 |
| rendering | 836.57 | 903.03 | 838.34 | 842.73 | 866.97 | 842.73 | 857.53 | 3.29 | 2.94 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||
| scripting | 156.31 | 154.35 | 159.38 | 167.32 | 162 | 159.38 | 159.87 | 3.18 | 2.85 |
| painting | 21.6 | 6.93 | 4.62 | 2.91 | 2.92 | 4.62 | 7.8 | 101.15 | 90.51 |
| rendering | 308.09 | 306.49 | 302.27 | 303.58 | 317.85 | 306.49 | 307.66 | 2.00 | 1.79 |
@dilippitchika This fix is for table widget v1. Will QA be able to test this out since we have table widget v2 already deployed?
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2831423406.
Workflow: Appsmith External Integration Test Workflow.
Commit: 14e2dec.
PR: 15549.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2845897900.
Workflow: Appsmith External Integration Test Workflow.
Commit: f062329.
PR: 15549.
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2845897900.
Commit: f062329.
Results: Click to view performance test results
| Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Median | Mean | SD.Sample | SD.Population | |
|---|---|---|---|---|---|---|---|---|---|
| SELECT_WIDGET_MENU_OPEN | |||||||||
| scripting | 1119.97 | 1156.91 | 1138.47 | 1067.67 | 1112.65 | 1119.97 | 1119.13 | 2.99 | 2.68 |
| painting | 7.55 | 13.09 | 13.94 | 10.76 | 12.25 | 12.25 | 11.52 | 21.79 | 19.44 |
| rendering | 850.14 | 868.88 | 877.22 | 865.76 | 872.76 | 868.88 | 866.95 | 1.19 | 1.07 |
| SELECT_WIDGET_SELECT_OPTION | |||||||||
| scripting | 190.61 | 171.95 | 164.2 | 152.72 | 156.35 | 164.2 | 167.17 | 9.01 | 8.06 |
| painting | 3.75 | 2.38 | 4.44 | 4.18 | 5.16 | 4.18 | 3.98 | 25.88 | 23.12 |
| rendering | 354.26 | 303.48 | 306.37 | 309.55 | 312.09 | 309.55 | 317.15 | 6.62 | 5.92 |