approvals
BinaryWriter
What's the status of BinaryWriter? Is it still used? If I comment the whole file out, not a single test fails, and 'BinaryWriter' is mentioned nowhere else in the source.
Wait. Dang it. I can't remember if someone else submitted it. What does blame say?
Yeah, no. @BadQuanta added the binary writer, so I'll assume that it's in use.
@BadQuanta - would you confirm?
It's possible to configure which writer you want to use when you're writing the test, so it doesn't have to be mentioned elsewhere in the codebase to be used, but if it's in use we should add tests for it.
I had been using it for a project that I've since let go inactive for a bit but plan on returning to this summer. It approved S.D.L. lib generated output. I'd still like the ability to dump and compare binaries, but if someone wants to put in something that handles images specifically that would be cool with me. And I'd be willing to help as much as I could.
On Wed, Feb 19, 2014 at 12:15 PM, Katrina Owen [email protected]:
Yeah, no. @BadQuanta https://github.com/BadQuanta added the binary writer, so I'll assume that it's in use.
@BadQuanta https://github.com/BadQuanta - would you confirm?
It's possible to configure which writer you want to use when you're writing the test, so it doesn't have to be mentioned elsewhere in the codebase to be used, but if it's in use we should add tests for it.
Reply to this email directly or view it on GitHubhttps://github.com/kytrinyx/approvals/issues/37#issuecomment-35542977 .
Jon S.
Email: [email protected]
