sourcekit-lsp icon indicating copy to clipboard operation
sourcekit-lsp copied to clipboard

build: remove swift-system dependency

Open compnerd opened this issue 2 years ago • 5 comments

tools-support-core has dropped this dependency which now allows us to remove the dependency as well.

compnerd avatar Nov 30 '23 22:11 compnerd

@swift-ci please test

compnerd avatar Nov 30 '23 22:11 compnerd

CC: @neonichu

compnerd avatar Nov 30 '23 22:11 compnerd

Not sure we can remove it here since SwiftPM still depends on it and sourcekit-lsp depends on SwiftPM

neonichu avatar Nov 30 '23 22:11 neonichu

Oh, I thought we removed it in SwiftPM as well.

compnerd avatar Nov 30 '23 23:11 compnerd

I had a PR for it, but @tomerd was saying we may need the dependency there at some point, so we shouldn't remove it.

neonichu avatar Dec 01 '23 00:12 neonichu

Closing because as @neonichu said we still have the SwiftSystem dependency in SwiftPM and thus still need it.

ahoppen avatar Jun 06 '24 13:06 ahoppen