pkl icon indicating copy to clipboard operation
pkl copied to clipboard

Download instructions in installation docs point to invalid URL

Open jasongwartz opened this issue 2 years ago • 4 comments

The docs on installation currently suggest the following instructions to download the executable:

curl -o pkl https://github.com/apple/pkl/releases/download/0.25.1/pkl-cli-macos-0.25.1.bin
chmod +x pkl
./pkl --version

but the URL https://github.com/apple/pkl/releases/download/0.25.1/pkl-cli-macos-0.25.1.bin is invalid:

$ curl -I https://github.com/apple/pkl/releases/download/0.25.1/pkl-cli-macos-0.25.1.bin
HTTP/2 404
...

The current release page includes separate ARM vs Intel binaries, which link to eg: https://github.com/apple/pkl/releases/download/0.25.1/pkl-macos-amd64 which itself is a 302 redirect to a https://objects.githubusercontent.com/github-production-release-asset-2e65be/745600812/... URL containing the actual binary.

I was able to curl -L the https://github.com/apple/pkl/releases/download/0.25.1/pkl-macos-amd64 URL to get a working binary.

I'm guessing this requires a doc change in or around here: https://github.com/apple/pkl/blob/ce65290aae9c407603a26401d9ac03277bb5de7b/docs/modules/pkl-cli/pages/index.adoc?plain=1#L4 but possibly a bit of new content explaining which build to choose based on system architecture.

Happy to make a PR if it would help!

jasongwartz avatar Feb 03 '24 00:02 jasongwartz

Thanks for this!

Is this binary notarized? I got an pop-up on macOS Sonoma 14.0.

bielikb avatar Feb 03 '24 08:02 bielikb

Same here:

image

finestructure avatar Feb 03 '24 09:02 finestructure

I generally struggle with these popups if I click to download a binary from Chrome, but it generally works fine with curl or if I run xattr -d com.apple.quarantine ./pcl

jackkleeman avatar Feb 03 '24 10:02 jackkleeman

This is also the case for installing the Linux executable on amd64:

$ curl -I https://github.com/apple/pkl/releases/download/0.25.1/pkl-cli-linux-amd64-0.25.1.bin
HTTP/2 404
server: GitHub.com

I was able to get the executable by using: $ curl -L -o pkl https://github.com/apple/pkl/releases/download/0.25.1/pkl-linux-amd64

petersid2022 avatar Feb 03 '24 12:02 petersid2022

Fixed by #21

holzensp avatar Feb 08 '24 14:02 holzensp

Thanks @holzensp !

jasongwartz avatar Feb 08 '24 21:02 jasongwartz