pkl icon indicating copy to clipboard operation
pkl copied to clipboard

"Source code" link in pkl packages website broken

Open morganhein opened this issue 1 year ago • 2 comments

The "source code" link on the pkl packages website is broken. For example, here:

https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-go/pkl.golang/current/GeneratorSettings/index.html

The "source code" links to: https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-go/pkl.golang/current/GeneratorSettings/https%3A//github.com/apple/pkl-go/tree/v0.5.3/codegen/src/GeneratorSettings.pkl

Which does not work.

morganhein avatar Feb 14 '24 18:02 morganhein

Thanks!

bioball avatar Feb 14 '24 18:02 bioball

Looks like a regression in the documentation generator (as if someone changed a proper URL resolve to string concatenation... 😬): if you select older versions 0.5.1 or 0.5.0, (but not 0.5.2 or 0.5.3) then the link works

image

(and then you can fixup the URL to version 0.5.3, of course, or notice that the end of the URL https%3A//github.com/apple/pkl-go/tree/v0.5.3/codegen/src/GeneratorSettings.pkl in the broken link can be URL-decoded to the same).


I'm here because I was curious about AppEnvCluster which is showing the same problem.

sparecycles avatar Mar 01 '24 15:03 sparecycles