llvm-project icon indicating copy to clipboard operation
llvm-project copied to clipboard
verified publisher icon apple

[LLDB][ELF] Fix section unification to not just use names.

Open al45tair opened this issue 1 year ago • 5 comments

Section unification cannot just use names, because it's valid for ELF binaries to have multiple sections with the same name. We should check other section properties too.

rdar://124467787

al45tair avatar Apr 30 '24 14:04 al45tair

This is a cherry pick of https://github.com/llvm/llvm-project/pull/90099

al45tair avatar Apr 30 '24 14:04 al45tair

@swift-ci Please test

al45tair avatar Apr 30 '24 14:04 al45tair

The macOS failure doesn't appear to be related to the changes in this PR.

al45tair avatar Apr 30 '24 16:04 al45tair

@swift-ci Please test macOS platform

al45tair avatar May 01 '24 08:05 al45tair

:-) I'm told we don't actually need this one anyway, because there's an auto merger that will take #8699 and apply it here.

al45tair avatar May 04 '24 08:05 al45tair

Closing as #8699 has been merged and the auto merger has done its job.

al45tair avatar May 07 '24 10:05 al45tair