foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard
verified publisher icon apple

Set knobs using environment variables when running Joshua

Open dlambrig opened this issue 3 years ago • 15 comments

For background see https://github.com/apple/foundationdb/issues/7667

When fdbserver starts, environment variables prefixed by FDB_KNOB_foo=bar are found and knob foo will be set to bar. The knob name (foo) must be in lower case; consistent with the cli option --knob. If both a cli option and environment variable set the same knob, the later wins.

The TestHarness is changed to propagate environment variables with prefix FDB_KNOB_ to fdbserver. The --env option can be used when starting a test.

j start --env FDB_KNOB_enable_version_vector=1 --tarball ~/cbuild_output/packages/correctness-7.2.0.tar.gz

Tested by starting the Joshua agent against a local fdbserver. Confirmed the fdbserver processes knobs according to the --env parameter. e.g., when a version vector knob was set to true using --env, a code coverage trace corresponding to the knob appeared in the summary.xml as expected.

The global environ works across Windows/MacOS/Linux OS.

Joshua 20220810-014936-henrylambright-80eaeb7f0aa13ea1

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

dlambrig avatar Aug 02 '22 18:08 dlambrig

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c36c9301f684ace6984f0b84623d3f8673c11820
  • Duration 0:09:01
  • Result: :x: FAILED
  • Error: reference not found for primary source and source version c36c9301f684ace6984f0b84623d3f8673c11820
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 02 '22 18:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c36c9301f684ace6984f0b84623d3f8673c11820
  • Duration 0:09:37
  • Result: :x: FAILED
  • Error: reference not found for primary source and source version c36c9301f684ace6984f0b84623d3f8673c11820
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 02 '22 18:08 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 4a25f8b6922868c9b58a46db3b16065be3a9b39f
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 02 '22 19:08 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 473feef2469026df3b7297d1044729015cafc259
  • Duration 0:56:15
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 02 '22 19:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 4a25f8b6922868c9b58a46db3b16065be3a9b39f
  • Duration 0:55:15
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 02 '22 19:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 473feef2469026df3b7297d1044729015cafc259
  • Duration 1:34:33
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 02 '22 20:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 4a25f8b6922868c9b58a46db3b16065be3a9b39f
  • Duration 1:34:28
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 02 '22 20:08 foundationdb-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 9bcb23c01af3c2958543468e28b8e5eaf31fd204
  • Duration 0:06:41
  • Result: :x: FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 06 '22 17:08 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 9bcb23c01af3c2958543468e28b8e5eaf31fd204
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 06 '22 18:08 fdb-windows-ci

Doxense CI Report for Windows 10

  • Commit ID: f9866f419a2a0a5aaa487f18caf53e4497436293
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 06 '22 18:08 fdb-windows-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: f9866f419a2a0a5aaa487f18caf53e4497436293
  • Duration 0:37:12
  • Result: :x: FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 06 '22 18:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 9bcb23c01af3c2958543468e28b8e5eaf31fd204
  • Duration 1:06:05
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 06 '22 18:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: f9866f419a2a0a5aaa487f18caf53e4497436293
  • Duration 0:56:44
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 06 '22 19:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 9bcb23c01af3c2958543468e28b8e5eaf31fd204
  • Duration 1:33:52
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 06 '22 19:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f9866f419a2a0a5aaa487f18caf53e4497436293
  • Duration 1:42:59
  • Result: :x: FAILED
  • Error: Error while executing command: make -C tests test_ycsb.run. Reason: exit status 2
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 06 '22 19:08 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: d5b8f8639f9f270bb12d675114686e76ab231e55
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 23 '22 17:08 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: d5b8f8639f9f270bb12d675114686e76ab231e55
  • Duration 1:12:11
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 23 '22 17:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: d5b8f8639f9f270bb12d675114686e76ab231e55
  • Duration 4:16:33
  • Result: :x: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 23 '22 20:08 foundationdb-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 5f490d3b85872c2ec12bd5a4616e8f0c9abd1940
  • Duration 0:11:54
  • Result: :x: FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 23 '22 21:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 8a00d0539f89bee6503a193ef7f9082dc64c0c9b
  • Duration 0:09:20
  • Result: :x: FAILED
  • Error: reference not found for primary source and source version 8a00d0539f89bee6503a193ef7f9082dc64c0c9b
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 23 '22 21:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 8a00d0539f89bee6503a193ef7f9082dc64c0c9b
  • Duration 0:10:09
  • Result: :x: FAILED
  • Error: reference not found for primary source and source version 8a00d0539f89bee6503a193ef7f9082dc64c0c9b
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 23 '22 21:08 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: c82d5cfa6d2aa2f069c0e85b1f21ad3310c48f22
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 23 '22 21:08 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 5f490d3b85872c2ec12bd5a4616e8f0c9abd1940
  • Duration 1:17:49
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 23 '22 22:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c82d5cfa6d2aa2f069c0e85b1f21ad3310c48f22
  • Duration 1:11:28
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 23 '22 22:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 50be189a0fbda8dd450c0786ecf0646d9dfbb1fc
  • Duration 1:15:54
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 23 '22 22:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 5f490d3b85872c2ec12bd5a4616e8f0c9abd1940
  • Duration 4:04:23
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 24 '22 01:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 50be189a0fbda8dd450c0786ecf0646d9dfbb1fc
  • Duration 4:17:04
  • Result: :x: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 24 '22 01:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c82d5cfa6d2aa2f069c0e85b1f21ad3310c48f22
  • Duration 4:16:29
  • Result: :x: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 24 '22 01:08 foundationdb-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: bbfc5009e214fcc6fb1af75d0b1a0a42e3cc14d5
  • Duration 0:07:09
  • Result: :x: FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 24 '22 17:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 2b850af6e9ed6c92c6363abb221532ad8ee67158
  • Duration 0:45:17
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 24 '22 18:08 foundationdb-ci