foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard
verified publisher icon apple

cherry pick 7653 - Track when version not found in version vector.

Open dlambrig opened this issue 3 years ago • 17 comments

Cherry pick pr #7653

Add new counter to track when the commit version for an SS is not taken from the version vector. When version vector is enabled there may be a performance hit in that situation. Performance diagnosis is harder without it. The counter should normally be 0.

Joshua: 20220729-005942-henrylambright-0ab2bd109c3dd379

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

dlambrig avatar Jul 22 '22 15:07 dlambrig

Doxense CI Report for Windows 10

  • Commit ID: 558c5e4f188dcf73333e2ccb3cf2aafd796852ac
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Jul 22 '22 15:07 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 558c5e4f188dcf73333e2ccb3cf2aafd796852ac
  • Duration 0:45:17
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 22 '22 15:07 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 558c5e4f188dcf73333e2ccb3cf2aafd796852ac
  • Duration 3:34:11
  • Result: :x: FAILED
  • Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 22 '22 18:07 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: ea95420823fad9f41474fb7600be082a0d5c21f2
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Jul 22 '22 19:07 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: ea95420823fad9f41474fb7600be082a0d5c21f2
  • Duration 0:52:06
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 22 '22 19:07 foundationdb-ci

looks like there is a bug in the downgrade test. Moving to draft state until we fix it.

dlambrig avatar Jul 22 '22 20:07 dlambrig

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: ea95420823fad9f41474fb7600be082a0d5c21f2
  • Duration 4:17:07
  • Result: :x: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 22 '22 23:07 foundationdb-ci

looks like there is a bug in the downgrade test. Moving to draft state until we fix it.

porting the fix to this from main branch.

dlambrig avatar Jul 29 '22 01:07 dlambrig

Doxense CI Report for Windows 10

  • Commit ID: b4ba9ae4989410b6beb2ce14ef0e52a7fa64aacd
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Jul 29 '22 01:07 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b4ba9ae4989410b6beb2ce14ef0e52a7fa64aacd
  • Duration 1:09:59
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 29 '22 02:07 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a62282a1b6d3b445eac401120f590ded66585534
  • Duration 1:11:16
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 29 '22 02:07 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b4ba9ae4989410b6beb2ce14ef0e52a7fa64aacd
  • Duration 1:26:45
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 29 '22 02:07 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a62282a1b6d3b445eac401120f590ded66585534
  • Duration 1:27:50
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 29 '22 02:07 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: fcad3b0dff885b35b0ad9307f9970b315fbbd0da
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 07 '22 00:08 fdb-windows-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: fcad3b0dff885b35b0ad9307f9970b315fbbd0da
  • Duration 0:34:18
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 07 '22 00:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: fcad3b0dff885b35b0ad9307f9970b315fbbd0da
  • Duration 0:57:48
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 07 '22 01:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: fcad3b0dff885b35b0ad9307f9970b315fbbd0da
  • Duration 1:18:47
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 07 '22 01:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c5fa15577bea6ff21a30d02d2fc7310c7fb728dc
  • Duration 0:48:26
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 19 '22 21:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c5fa15577bea6ff21a30d02d2fc7310c7fb728dc
  • Duration 1:52:58
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 19 '22 22:08 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: c5fa15577bea6ff21a30d02d2fc7310c7fb728dc
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 19 '22 22:08 fdb-windows-ci

Doxense CI Report for Windows 10

  • Commit ID: af096aac291e9da1a5b737ba9345cf73f9832aaf
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 24 '22 20:08 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: af096aac291e9da1a5b737ba9345cf73f9832aaf
  • Duration 1:09:57
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 24 '22 21:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: af096aac291e9da1a5b737ba9345cf73f9832aaf
  • Duration 2:01:47
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 24 '22 22:08 foundationdb-ci