foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Fix/make all python code pythonic

Open LukasMoll opened this issue 3 years ago • 124 comments

I am going to make the python files more Pythonic and clean up the code. folders TODO:

  • [x] bindings - 32 files
  • [x] contrib - 18 files
  • [x] documentation - 4 files
  • [x] fdbrpc - 1 file
  • [x] layers - 18 files
  • [x] packaging - 3 files
  • [x] recipes - 8 files
  • [x] tests - 13 files

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

LukasMoll avatar May 01 '22 15:05 LukasMoll

Doxense CI Report for Windows 10

  • Commit ID: b64ef83a57e9387d60ab90912b6158e59fe122e7
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 01 '22 15:05 fdb-windows-ci

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: b64ef83a57e9387d60ab90912b6158e59fe122e7
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 01 '22 16:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: b64ef83a57e9387d60ab90912b6158e59fe122e7
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 01 '22 17:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 093a3a86d1df43d865733875170315d516d0d775
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 06 '22 12:05 fdb-windows-ci

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: 093a3a86d1df43d865733875170315d516d0d775
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 06 '22 12:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 093a3a86d1df43d865733875170315d516d0d775
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 06 '22 13:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 3781fc8683c63e1e710f29cb44caab7eb0e10cba
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 09 '22 15:05 fdb-windows-ci

Doxense CI Report for Windows 10

  • Commit ID: 18ce9a5a876c5ebf710e4281dc23c1f420dc8f77
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 09 '22 15:05 fdb-windows-ci

Doxense CI Report for Windows 10

  • Commit ID: 2476d98f7b7a0959849b6ae49ef9e034a1e46d5b
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 09 '22 15:05 fdb-windows-ci

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: 18ce9a5a876c5ebf710e4281dc23c1f420dc8f77
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 09 '22 15:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 3781fc8683c63e1e710f29cb44caab7eb0e10cba
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 09 '22 16:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 18ce9a5a876c5ebf710e4281dc23c1f420dc8f77
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 09 '22 16:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 2476d98f7b7a0959849b6ae49ef9e034a1e46d5b
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 09 '22 16:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: e4a7b34e70396b6af77fb4ea0fb7c17d353dd937
  • Result: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 10:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 81266346bb8ca63f45bd649cd659adf0f6abc24f
  • Result: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 10:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: e4a7b34e70396b6af77fb4ea0fb7c17d353dd937
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 21 '22 10:05 fdb-windows-ci

Doxense CI Report for Windows 10

  • Commit ID: 81266346bb8ca63f45bd649cd659adf0f6abc24f
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 21 '22 11:05 fdb-windows-ci

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: e4a7b34e70396b6af77fb4ea0fb7c17d353dd937
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 11:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 419f6fd2f8b87c0bb2251672e255b650b012b02c
  • Result: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 11:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: a56279444c894c675e59094a2d1b7505d059c23f
  • Result: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 11:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 419f6fd2f8b87c0bb2251672e255b650b012b02c
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 21 '22 11:05 fdb-windows-ci

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: a56279444c894c675e59094a2d1b7505d059c23f
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 12:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 83ed710d5aac2e34002a896be4be01f85695c61d
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 21 '22 12:05 fdb-windows-ci

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: 2476d98f7b7a0959849b6ae49ef9e034a1e46d5b
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 13:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 83ed710d5aac2e34002a896be4be01f85695c61d
  • Result: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 13:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 2476d98f7b7a0959849b6ae49ef9e034a1e46d5b
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 13:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 9b8d7a65e3026f3c0ef707f69bb32a94c5c493be
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 21 '22 14:05 fdb-windows-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: db1bd7b3e50c049e66fd5b56dab3f256001d0f3e
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 15:05 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 9b8d7a65e3026f3c0ef707f69bb32a94c5c493be
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar May 21 '22 15:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: eb50bf349dbdb349fd92fda1d70d9203b96c243b
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 21 '22 19:05 fdb-windows-ci